Conversation
Added code to trap for the conditions when E+ can crash. When Do HVAC is YES but Do Plant is NO and there are no Sizing:Plant objects, a warning error is produced and Do HVAC is set to NO. When there are no Sizing:Plant objects and both Do HVAC and Do Plant are YES, a severe/fatal error is produced.
Added a unit test, modified an existing one, and added a sentence to the IO Ref to complete the correct for Defect #10797
|
Contributor
Author
|
FYI: The difference in the ci is in 5ZoneIceStorage which has a SimulationControl that assigns Do HVAC Sizing - yes and Do Plant Sizing - no. Now in this particular file, it avoided an error before because it actually had Sizing:Plant objects. If those objects were gone, then it likely would have crashed. |
This file fails with the modified code because Do HVAC Sizing was set to Yes and Do Plant Sizing was set to No. Now both are set to Yes.
Contributor
Author
|
I went back and corrected 5ZoneIceStorage to avoid the error. After ci finishes, this should be ready for review. |
|
mdahlhausen
added a commit
to NatLabRockies/openstudio-standards
that referenced
this pull request
Jan 2, 2026
EnergyPlus version 25.2 errors out if Plant Sizing is set to true in the simulation control object, but the model has no Sizing:Plant objects. NatLabRockies/EnergyPlus#11140 In model_run_sizing_run, do plant sizing if and only if there are Sizing:Plant objects in the model.
ckirney
added a commit
to NatLabRockies/openstudio-standards
that referenced
this pull request
Feb 10, 2026
* add DEER service water assumptions using the existing DEER data in openstudio-standards; no attempt at reconciliation of differences between typical service water with ASHRAE prototypes * setDoPlantSizingCalculation only if SizingPlant objects EnergyPlus version 25.2 errors out if Plant Sizing is set to true in the simulation control object, but the model has no Sizing:Plant objects. NatLabRockies/EnergyPlus#11140 In model_run_sizing_run, do plant sizing if and only if there are Sizing:Plant objects in the model. * Update version.rb * clean up climate zone value getters/setters --------- Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
ckirney
added a commit
to NatLabRockies/openstudio-standards
that referenced
this pull request
Feb 13, 2026
* remove college - and courthouse - prefixes
- remove the "College - " and "Courthouse - " prefixes to space type names. These are not necessary as they are already attached to a building type.
- add missing DEER space types from prototype_space_type_map
- fix some typos in prototype_space_type_map
* rename thermal_zone_add_unconditioned_thermostat
- rename thermal_zone_add_unconditioned_thermostat to thermal_zone_set_unconditioned_thermostat
- fix cooling schedule name
* rename thermal_zone module file
rename to information to match other modules. All methods are to get thermal zone information
* move thermal_zone_set_unconditioned_thermostat
move thermal_zone_set_unconditioned_thermostat to new thermostat_schedules file to contain all thermostat schedule methods for thermal zones
* method and data for thermostat schedule lookup
Use the ComStock templates to generate a thermostat_schedule_lookup.json.
The thermostat schedules will be attached to space types, with variation by building type.
The ComStock template will disappear soon; this commit is a log of how the thermostat schedule_lookup was generated, using the templates as they existed in openstudio-standards. (0.8.4, with edits to support incomplete space types. Possibly 0.8.5 - see commits around this time.).
* log message notation update
* rename test_thermal_zone to test_thermal_zone_information
* minor ci error fixes
- small office space name changed, b/c of overlap with space type name
- space type name update
* add method to set zone thermostats
add thermal_zones_set_thermostat_schedules method, which pulls from the thermostat_schedule_lookup json to set thermostats depending on the zone standards space type and building type
* Add thermal comfort model options
Update Standards.People.rb to include a thermal comfort model option in space_type_apply_people
* split thermostats from space_type_apply_internal_load_schedules
Move thermostat creation by space type from space_type_apply_internal_load_schedules to space_type_apply_thermostat_schedules. This will keep consistency with prototype and NECB models.
For create_typical, use the new thermal_zones_set_thermostat_schedules method
* use PeopleDefinition object, not People
* Dissabling some Gemfiles
* Updating Gemfile.lock.3.9.0 (#2035)
* Update thermostat_schedule_lookup.json
use older QSR thermostat setpoint schedules; newer ones have issues in parametric code
* data_update a6cb1e7
* Merge master changes into nrcan_472c branch (#2038)
* remove college - and courthouse - prefixes
- remove the "College - " and "Courthouse - " prefixes to space type names. These are not necessary as they are already attached to a building type.
- add missing DEER space types from prototype_space_type_map
- fix some typos in prototype_space_type_map
* minor ci error fixes
- small office space name changed, b/c of overlap with space type name
- space type name update
---------
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
* Move test sql and osm files. Revert changes to non-NRCan code.
* Fixing paths. Resetting weather file path in file if the .osm weather file does not exist at the given path.
* Updating ci_tests.txt
* Nrcan 472c (#2039)
* Updating Gemfile.lock.3.9.0
* Merge master changes into nrcan_472c branch (#2038)
* remove college - and courthouse - prefixes
- remove the "College - " and "Courthouse - " prefixes to space type names. These are not necessary as they are already attached to a building type.
- add missing DEER space types from prototype_space_type_map
- fix some typos in prototype_space_type_map
* minor ci error fixes
- small office space name changed, b/c of overlap with space type name
- space type name update
---------
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
* Move test sql and osm files. Revert changes to non-NRCan code.
* Fixing paths. Resetting weather file path in file if the .osm weather file does not exist at the given path.
* Updating ci_tests.txt
---------
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
* Update Gemfile.lock.3.9.0
* Deleting excess regression test files
* Updating 90.1 SmallOffice Regression tests
* Updating 90.1 SmallOffice Regression tests (#2040)
* Disabling caching by default but still retaining the functionality to use it if desired.
* Moved and renamed the test helper since it's not a test
* Reverting SmallOffice OSM files from master
* Removing automatic caching of OSM and SQL files
* Removing cached OSM and SQL files
* Removing comments associated with caching
* Updated test_list file for costing and test_run_all_test_locally.rb to include the test helpere
* Renamed "Htg" back to "Clg" in Standards.CoilHeatingDXSingleSpeed.rb
* Update with changes from master. (#2041)
* remove college - and courthouse - prefixes
- remove the "College - " and "Courthouse - " prefixes to space type names. These are not necessary as they are already attached to a building type.
- add missing DEER space types from prototype_space_type_map
- fix some typos in prototype_space_type_map
* rename thermal_zone_add_unconditioned_thermostat
- rename thermal_zone_add_unconditioned_thermostat to thermal_zone_set_unconditioned_thermostat
- fix cooling schedule name
* rename thermal_zone module file
rename to information to match other modules. All methods are to get thermal zone information
* move thermal_zone_set_unconditioned_thermostat
move thermal_zone_set_unconditioned_thermostat to new thermostat_schedules file to contain all thermostat schedule methods for thermal zones
* method and data for thermostat schedule lookup
Use the ComStock templates to generate a thermostat_schedule_lookup.json.
The thermostat schedules will be attached to space types, with variation by building type.
The ComStock template will disappear soon; this commit is a log of how the thermostat schedule_lookup was generated, using the templates as they existed in openstudio-standards. (0.8.4, with edits to support incomplete space types. Possibly 0.8.5 - see commits around this time.).
* log message notation update
* rename test_thermal_zone to test_thermal_zone_information
* minor ci error fixes
- small office space name changed, b/c of overlap with space type name
- space type name update
* add method to set zone thermostats
add thermal_zones_set_thermostat_schedules method, which pulls from the thermostat_schedule_lookup json to set thermostats depending on the zone standards space type and building type
* Add thermal comfort model options
Update Standards.People.rb to include a thermal comfort model option in space_type_apply_people
* split thermostats from space_type_apply_internal_load_schedules
Move thermostat creation by space type from space_type_apply_internal_load_schedules to space_type_apply_thermostat_schedules. This will keep consistency with prototype and NECB models.
For create_typical, use the new thermal_zones_set_thermostat_schedules method
* use PeopleDefinition object, not People
* Update thermostat_schedule_lookup.json
use older QSR thermostat setpoint schedules; newer ones have issues in parametric code
---------
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
* Adding costing test results to .gitignore
* Reverting changes to DX heating coil naming
* Update regression test results to reflect changes to naming
* Nrcan 472c (#2042)
* Update with changes from master. (#2041)
* remove college - and courthouse - prefixes
- remove the "College - " and "Courthouse - " prefixes to space type names. These are not necessary as they are already attached to a building type.
- add missing DEER space types from prototype_space_type_map
- fix some typos in prototype_space_type_map
* rename thermal_zone_add_unconditioned_thermostat
- rename thermal_zone_add_unconditioned_thermostat to thermal_zone_set_unconditioned_thermostat
- fix cooling schedule name
* rename thermal_zone module file
rename to information to match other modules. All methods are to get thermal zone information
* move thermal_zone_set_unconditioned_thermostat
move thermal_zone_set_unconditioned_thermostat to new thermostat_schedules file to contain all thermostat schedule methods for thermal zones
* method and data for thermostat schedule lookup
Use the ComStock templates to generate a thermostat_schedule_lookup.json.
The thermostat schedules will be attached to space types, with variation by building type.
The ComStock template will disappear soon; this commit is a log of how the thermostat schedule_lookup was generated, using the templates as they existed in openstudio-standards. (0.8.4, with edits to support incomplete space types. Possibly 0.8.5 - see commits around this time.).
* log message notation update
* rename test_thermal_zone to test_thermal_zone_information
* minor ci error fixes
- small office space name changed, b/c of overlap with space type name
- space type name update
* add method to set zone thermostats
add thermal_zones_set_thermostat_schedules method, which pulls from the thermostat_schedule_lookup json to set thermostats depending on the zone standards space type and building type
* Add thermal comfort model options
Update Standards.People.rb to include a thermal comfort model option in space_type_apply_people
* split thermostats from space_type_apply_internal_load_schedules
Move thermostat creation by space type from space_type_apply_internal_load_schedules to space_type_apply_thermostat_schedules. This will keep consistency with prototype and NECB models.
For create_typical, use the new thermal_zones_set_thermostat_schedules method
* use PeopleDefinition object, not People
* Update thermostat_schedule_lookup.json
use older QSR thermostat setpoint schedules; newer ones have issues in parametric code
---------
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
* Reverting changes to DX heating coil naming
* Update regression test results to reflect changes to naming
---------
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
* Including SEER in DX single speed heating coil options.
* Removing debug comments.
* Fixing typo
* Fixing typo (#2043)
* space type adjustments
* Update regression tests based on adjustments to code.
* Fix #2044 - Remove Oniguruma Lookbehind with unicode matcher and similar constructs
* Nrcan 472c (#2046)
* Fixing typo
* Update regression tests based on adjustments to code.
* Upating HS14 costing test
* Nrcan 472c (#2050)
* Fixing typo
* Update regression tests based on adjustments to code.
* Upating HS14 costing test
* change 90_1_prm files back to master version
* rubocop fixes
* add create_typical_equipment method
- add gas and electric equipment space type jsons
- add create_typical_equipment method
- add test
* fix log reference
* add more decimals to water use def name
* move radiant system controls to hvac module
* change from Standard to HVAC module
* move transformers to equipment module
* change model_add_transformer to create_transformer
- edit code instances throughout
* Update refrigeration_compressors.csv
* Inculding DX coil capacity modifications in case of sizing run errors.
* update doe regression models
* Updating dx coil changes to properly catch the DX coils with problems and make changes more efficient.
* Update geometry.rb
use code directly; don't require another module to get simple object properties
* update NECB regression tests
* Nrcan 478 (#2059)
* Including changes from master (#2033)
* HVAC components boiler
- move create_boiler_hot_water to module
- add tests for create_boiler_hot_water and create_hx_air_to_air_sensible_and_latent
* move create coil methods to HVAC module
* move create central air source heat pump method
* move create air conditioner vrf to HVAC module
* move HVAC conversions to HVAC module
* move create curve methods to HVAC module
- also change arguments to optional keyword arguments
* rename files by component
* consolidate and rename hx methods
* update component documentation grouping
* update log message locations
* add pump module
- move pump_variable_speed_set_control_type method to module
- move pump flow rate, power, etc. methods to module
- update HVAC code with new method locations
- add tests
* move template prototype pump methods to standards
* create helper methods module
- move methods from prototype utilities to helper methods module or other appropriate existing file
* fix reference
- load helper method module
- rename file to have rb extension
* Update central_air_source_heat_pump.rb
* move cooling coil capacity methods
* remove redundant headered pump coefficients method
remove redundant pump control type coefficients method for headered pumps as the coefficients and setter methods are the same for a variable speed pump. Add headered pumps as an input pump_variable_speed_set_control_type method.
* remove redundant fan files
* add missing module call
* move vrf get capacity method
air_conditioner_variable_refrigerant_flow_find_capacity -> air_conditioner_variable_refrigerant_flow_get_capacity
* capacity methods
move get capacity methods from Standards to the HVAC module
* capacity method for gas multi coils
* heating coil paired cooling capacity methods
* move air terminal reheat type method
* generalize paired cooling coil capacity method
* move coil_dx_heating_type method
* fix module method reference
* fix pump method call
* make individual hvac module component test files
* add tests for component capacity methods
* fan component refactor
* call module method create_fan_by_name
* fix create fan method names
* fix create fan method calls
* fix call to fan_variable_volume_set_control_type
* fix typos in method calls
* fix method call to coil capacity
* fix argument type and variable name errors
* fix name for fan curve type
* add create_fan_system_model method
Addresses #1521
* standards coil heating merge changes
* Update coil.rb
* missing module call
* set pressure rise for constant volume fans
Unit heaters were improperly excluded from having their pressure rise set. Also set a default in the data.
* fix logic for thermal zone check
* support unitary system in coil_dx_heat_pump?
- fixes #1954
- adds tests for coil methods
* Update coil.rb
* check for nil capacity before conversions
* prm hvac check fixes
- in prm baseline check, only add ptac to conditioned zones
- change PTAC fan type to constantvolume
* change fan type back to OnOff
* update regression models
* Update Prototype.hvac_systems.rb
method now in module
* Update test_performance_expected_dd_results.csv
* Renabling some tests and disabling some gems and require statements
* Updating covert_arg_to_bool to work as intended (#1993) (#1994)
* Re-enable some NREL tests
* create_typical_exterior_lighting method name
change model_create_typical_exterior_lighting to create_typical_exterior_lighting to align with other create methods
change model_get_exterior_lighting_properties to exterior_lighting_properties
* Nrcan 460 merge (#2000)
* data_update b8458b8
* change water temperatures to mixed temperatures
- Change water use temperatures to be the mixed water temperature. This is necessary because the faucet temps should be lower to account for heat loss in pipes and mixing. The 140F water use temps the same as the loop and water heater temps were causing issues with sizing. The loop rarely hit the target temperature.
- Mixed water temperatures changed from 140F to 110F for most use cases, 120F in kitchens for general use. Keep 180F for dishwashers.
- The prior flow rates and schedules seemed to be mixed water use, not hot water use. As an example, a 20,000 ft2 office with 1000 ft2 of bathrooms would have 5 EFLH * 0.02 gph per ft2 * 1000 ft2 = 100 gallons mixed water use, whereas 100 gallons of 140F would be to high. The overall values will need to be checked and updated.
* set water heater sizing properties
- set minimum loop temperatures of 125F for service water heating loops for legionella risk
- change the sizing loop delta temperature to larger values
- set water heater tank recovery times depending on fuel, and set sizing to PeakDraw
* Updating covert_arg_to_bool to work as intended
* Updating some files which were eroneously updated.
* fix coil eff application to necb models
The NECB PTAC / PTHP efficiency data doesn't have the 'application' field, causing the lookup to return nil, and the efficiency application to return false. Since the vars hash gets successively passed, further methods failing when trying to set variables on the now false hash.
Fixes are to return the original hash instead of false in the apply method. And to add a check to only apply the application search field for 90.1 templates.
* change necb models to new minimum loop temperature
* update expected regression results
* fix comstock pthp efficiency lookup
90.1-2004 and 90.1-2007 ASHRAE heat pump heating efficiencies use 'New Construction' and 'Replacements' as the application type, rather than 'Standard Size'. When the template includes ComStock , it uses the ASHRAE 90.1 databases but didn't strictly match the template type, so the efficiency lookup would fail.
* change swh loop temperature difference to 5K
change the service hot water loop design temperature difference back to 5 Kelvin (9 Rankine) from prior values. The prior changes were causing very low temperatures on booster hot water loops. And more typical design differences are 5-10R.
* Replacing openstudio-standards require statment with require_relative path to openstudio-standards.rb.
* updates regression models
* Update version.rb
* Updating test_run_costing_tests.rb to use initial set of building types.
---------
Co-authored-by: Xuechen (Jerry) Lei <xuechen.lei@pnnl.gov>
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
Co-authored-by: Landan Taylor <128543626+LandanT@users.noreply.github.com>
* Removing timings.json file and including it in .gitnore
* Updating btap_workflow.rb and removing README.md files.
* Revert "Re-enable some NREL tests"
This reverts commit 3795e76dbd995056f899a014620c88e6c6faa66f.
* Merge branch 'master' into hvac_component_refactor
* Update hvac_systems.rb
* update doe regression models
* Fix broken generate_userdata_to_csv
* update NRCAN regression tests
* Fix #2006 - Do not instantiate unique model objects
* Unrelated typo in a test helper
* fix incorrect model call to unmet hours check
* Showcase error with Ground PRM constructions
I think the culprit is this PR: https://github.com/NREL/openstudio-standards/pull/1903
```
[openstudio.model.Model] The run did not finish and had following errors: BuildingSurface:Detailed="SURFACE 19", invalid Outside Boundary Condition Construction="TYPICAL INSULATED CARPETED 6IN SLAB FLOOR" is not type Construction:FfactorGroundFloor.\nBuildingSurface:Detailed="SURFACE 1", invalid Outside Boundary Condition Construction="TYPICAL INSULATED CARPETED 6IN SLAB FLOOR" is not type Construction:FfactorGroundFloor.\nBuildingSurface:Detailed="SURFACE 37", invalid Outside Boundary Condition Construction="TYPICAL INSULATED CARPETED 6IN SLAB FLOOR" is not type Construction:FfactorGroundFloor.\nBuildingSurface:Detailed="SURFACE 25", invalid Outside Boundary Condition Construction="TYPICAL INSULATED CARPETED 6IN SLAB FLOOR" is not type Construction:FfactorGroundFloor.\nBuildingSurface:Detailed="SURFACE 7", invalid Outside Boundary Condition Construction="TYPICAL INSULATED CARPETED 6IN SLAB FLOOR" is not type Construction:FfactorGroundFloor.\nBuildingSurface:Detailed="SURFACE 43", invalid Outside Boundary Condition Construction="TYPICAL INSULATED CARPETED 6IN SLAB FLOOR" is not type Construction:FfactorGroundFloor.\nBuildingSurface:Detailed="SURFACE 31", invalid Outside Boundary Condition Construction="TYPICAL INSULATED CARPETED 6IN SLAB FLOOR" is not type Construction:FfactorGroundFloor.\nBuildingSurface:Detailed="SURFACE 13", invalid Outside Boundary Condition Construction="TYPICAL INSULATED CARPETED 6IN SLAB FLOOR" is not type Construction:FfactorGroundFloor.\nBuildingSurface:Detailed="SURFACE 49", invalid Outside Boundary Condition Construction="TYPICAL INSULATED CARPETED 6IN SLAB FLOOR" is not type Construction:FfactorGroundFloor.\nGetSurfaceData: Errors discovered, program terminates.
/home/julien/Software/Others/openstudio_gems/openstudio-standards-master/test/90_1_prm/create_performance_rating_method_helper.rb:193:in `create_baseline_model
```
* model_add_construction: catch the case were the construction name is found but isn't the right type
* Ensure we don't create a Ffactor / Cfactor construction if we have no construction_props to populate it
* Allow passing custom exclusiosn to log_messages_to_runner
* Flip a condition, cheaper to evaluate the bool first
* Make it a keywoard argument instead, and default to nil
* deep copy f and c factor constructions
- need to deep copy f and c factor constructions so they are specific to an individual surface. Right now it will potentially use the same F/C factor construction and edit values, even if used in another space.
- There is a distinction we don't account for in space vs. surface. The F/C factor values are derived from space lengths and areas, not surface areas and lengths.
* fix missing coil argument
* use necb unit tests from master
* fix necb unit test module method references
* return capacity if no cooling coil
In the coil_heating_get_paired_coil_cooling_capacity, if there is no cooling coil, return the capacity before check multiplier methods that depend on cooling coil.
* disable test_necb_reference_heatpump_rules
Disable test_necb_reference_heatpump_rules test for now. See comments on the hvac_component_refactor PR #1943 for detail.
* remove deep copy
* Update version.rb
* move btap costing testing to test directory
* Update necb_2011.rb
* add interior lighting module data, method, tests
* add prototype space type mapping
* Implementing new transfer manager method.
* Fix typo
* Removing comments
* Do not fail container if running on AWS
* Udptae comment
* Always failing container to see if btap_batch fix worked.
* update prototype space type mapping and tests
* rubocop and yard doc edits
* assert both methods return true in tests
- fix typo in SuperMarket model name
- assert that model_set_building_location and prototype_space_type_map both return true
* split ventilation section into new method
* use keyword args in space type apply methods
make space_type_apply_internal_loads and space_type_apply_internal_load_schedules arguments into keyword args instead of default args.
* only update ventilation if set_ventilation true
* add files to yard docs
* fix space_type_apply_internal_loads test
* split people from space type apply loads
split out the people section of space_type_apply_internal_loads into a separate section of code
* fix typo
* Update Gemfile.lock.3.9.0.
* Update insuite_central_doas_LargeHotel_one_sys_per_dwelling_unit_expected_results.json
Updating test results.
* inculding equality test
* Update unit test result to reflect airloop naming change (#2030)
* Removing code that deliberately breaks buildings with Electricity as the fuel type.
* Activating include statements (#2031)
* Include conditional failure report
---------
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
Co-authored-by: Xuechen (Jerry) Lei <xuechen.lei@pnnl.gov>
Co-authored-by: Landan Taylor <128543626+LandanT@users.noreply.github.com>
Co-authored-by: Julien Marrec <julien.marrec@gmail.com>
* Nrcan 472c (#2051)
* Merge master changes into nrcan_472c branch (#2038)
* remove college - and courthouse - prefixes
- remove the "College - " and "Courthouse - " prefixes to space type names. These are not necessary as they are already attached to a building type.
- add missing DEER space types from prototype_space_type_map
- fix some typos in prototype_space_type_map
* minor ci error fixes
- small office space name changed, b/c of overlap with space type name
- space type name update
---------
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
* Move test sql and osm files. Revert changes to non-NRCan code.
* Fixing paths. Resetting weather file path in file if the .osm weather file does not exist at the given path.
* Updating ci_tests.txt
* Update Gemfile.lock.3.9.0
* Updating 90.1 SmallOffice Regression tests
* Disabling caching by default but still retaining the functionality to use it if desired.
* Moved and renamed the test helper since it's not a test
* Reverting SmallOffice OSM files from master
* Removing automatic caching of OSM and SQL files
* Update with changes from master. (#2041)
* remove college - and courthouse - prefixes
- remove the "College - " and "Courthouse - " prefixes to space type names. These are not necessary as they are already attached to a building type.
- add missing DEER space types from prototype_space_type_map
- fix some typos in prototype_space_type_map
* rename thermal_zone_add_unconditioned_thermostat
- rename thermal_zone_add_unconditioned_thermostat to thermal_zone_set_unconditioned_thermostat
- fix cooling schedule name
* rename thermal_zone module file
rename to information to match other modules. All methods are to get thermal zone information
* move thermal_zone_set_unconditioned_thermostat
move thermal_zone_set_unconditioned_thermostat to new thermostat_schedules file to contain all thermostat schedule methods for thermal zones
* method and data for thermostat schedule lookup
Use the ComStock templates to generate a thermostat_schedule_lookup.json.
The thermostat schedules will be attached to space types, with variation by building type.
The ComStock template will disappear soon; this commit is a log of how the thermostat schedule_lookup was generated, using the templates as they existed in openstudio-standards. (0.8.4, with edits to support incomplete space types. Possibly 0.8.5 - see commits around this time.).
* log message notation update
* rename test_thermal_zone to test_thermal_zone_information
* minor ci error fixes
- small office space name changed, b/c of overlap with space type name
- space type name update
* add method to set zone thermostats
add thermal_zones_set_thermostat_schedules method, which pulls from the thermostat_schedule_lookup json to set thermostats depending on the zone standards space type and building type
* Add thermal comfort model options
Update Standards.People.rb to include a thermal comfort model option in space_type_apply_people
* split thermostats from space_type_apply_internal_load_schedules
Move thermostat creation by space type from space_type_apply_internal_load_schedules to space_type_apply_thermostat_schedules. This will keep consistency with prototype and NECB models.
For create_typical, use the new thermal_zones_set_thermostat_schedules method
* use PeopleDefinition object, not People
* Update thermostat_schedule_lookup.json
use older QSR thermostat setpoint schedules; newer ones have issues in parametric code
---------
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
* Reverting changes to DX heating coil naming
* Update regression test results to reflect changes to naming
* Including SEER in DX single speed heating coil options.
* Removing debug comments.
* Fixing typo
* Update regression tests based on adjustments to code.
* Upating HS14 costing test
---------
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
Co-authored-by: Nicholas Pneumaticos <nicholaspneu@gmail.com>
* Changed test class names so they're able to be run in the parallel test suite
* Removing comments associated with caching
---------
Co-authored-by: Chris Kirney <36897585+ckirney@users.noreply.github.com>
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
Co-authored-by: Xuechen (Jerry) Lei <xuechen.lei@pnnl.gov>
Co-authored-by: Landan Taylor <128543626+LandanT@users.noreply.github.com>
Co-authored-by: Julien Marrec <julien.marrec@gmail.com>
Co-authored-by: Chris Kirney <chris.kirney@canada.ca>
* update necb expected results
* round all water use object names to 4 sig figs
* update doe regression tests
* update necb regression models
* Nrcan 472c merge (#2062)
* remove college - and courthouse - prefixes
- remove the "College - " and "Courthouse - " prefixes to space type names. These are not necessary as they are already attached to a building type.
- add missing DEER space types from prototype_space_type_map
- fix some typos in prototype_space_type_map
* rename thermal_zone_add_unconditioned_thermostat
- rename thermal_zone_add_unconditioned_thermostat to thermal_zone_set_unconditioned_thermostat
- fix cooling schedule name
* rename thermal_zone module file
rename to information to match other modules. All methods are to get thermal zone information
* move thermal_zone_set_unconditioned_thermostat
move thermal_zone_set_unconditioned_thermostat to new thermostat_schedules file to contain all thermostat schedule methods for thermal zones
* method and data for thermostat schedule lookup
Use the ComStock templates to generate a thermostat_schedule_lookup.json.
The thermostat schedules will be attached to space types, with variation by building type.
The ComStock template will disappear soon; this commit is a log of how the thermostat schedule_lookup was generated, using the templates as they existed in openstudio-standards. (0.8.4, with edits to support incomplete space types. Possibly 0.8.5 - see commits around this time.).
* log message notation update
* rename test_thermal_zone to test_thermal_zone_information
* minor ci error fixes
- small office space name changed, b/c of overlap with space type name
- space type name update
* add method to set zone thermostats
add thermal_zones_set_thermostat_schedules method, which pulls from the thermostat_schedule_lookup json to set thermostats depending on the zone standards space type and building type
* Add thermal comfort model options
Update Standards.People.rb to include a thermal comfort model option in space_type_apply_people
* split thermostats from space_type_apply_internal_load_schedules
Move thermostat creation by space type from space_type_apply_internal_load_schedules to space_type_apply_thermostat_schedules. This will keep consistency with prototype and NECB models.
For create_typical, use the new thermal_zones_set_thermostat_schedules method
* use PeopleDefinition object, not People
* Dissabling some Gemfiles
* Updating Gemfile.lock.3.9.0 (#2035)
* Update thermostat_schedule_lookup.json
use older QSR thermostat setpoint schedules; newer ones have issues in parametric code
* data_update a6cb1e7
* Nrcan 472c (#2039)
* Updating Gemfile.lock.3.9.0
* Merge master changes into nrcan_472c branch (#2038)
* remove college - and courthouse - prefixes
- remove the "College - " and "Courthouse - " prefixes to space type names. These are not necessary as they are already attached to a building type.
- add missing DEER space types from prototype_space_type_map
- fix some typos in prototype_space_type_map
* minor ci error fixes
- small office space name changed, b/c of overlap with space type name
- space type name update
---------
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
* Move test sql and osm files. Revert changes to non-NRCan code.
* Fixing paths. Resetting weather file path in file if the .osm weather file does not exist at the given path.
* Updating ci_tests.txt
---------
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
* Deleting excess regression test files
* Updating 90.1 SmallOffice Regression tests (#2040)
* Removing cached OSM and SQL files
* Removing comments associated with caching
* Updated test_list file for costing and test_run_all_test_locally.rb to include the test helpere
* Renamed "Htg" back to "Clg" in Standards.CoilHeatingDXSingleSpeed.rb
* Adding costing test results to .gitignore
* Nrcan 472c (#2042)
* Update with changes from master. (#2041)
* remove college - and courthouse - prefixes
- remove the "College - " and "Courthouse - " prefixes to space type names. These are not necessary as they are already attached to a building type.
- add missing DEER space types from prototype_space_type_map
- fix some typos in prototype_space_type_map
* rename thermal_zone_add_unconditioned_thermostat
- rename thermal_zone_add_unconditioned_thermostat to thermal_zone_set_unconditioned_thermostat
- fix cooling schedule name
* rename thermal_zone module file
rename to information to match other modules. All methods are to get thermal zone information
* move thermal_zone_set_unconditioned_thermostat
move thermal_zone_set_unconditioned_thermostat to new thermostat_schedules file to contain all thermostat schedule methods for thermal zones
* method and data for thermostat schedule lookup
Use the ComStock templates to generate a thermostat_schedule_lookup.json.
The thermostat schedules will be attached to space types, with variation by building type.
The ComStock template will disappear soon; this commit is a log of how the thermostat schedule_lookup was generated, using the templates as they existed in openstudio-standards. (0.8.4, with edits to support incomplete space types. Possibly 0.8.5 - see commits around this time.).
* log message notation update
* rename test_thermal_zone to test_thermal_zone_information
* minor ci error fixes
- small office space name changed, b/c of overlap with space type name
- space type name update
* add method to set zone thermostats
add thermal_zones_set_thermostat_schedules method, which pulls from the thermostat_schedule_lookup json to set thermostats depending on the zone standards space type and building type
* Add thermal comfort model options
Update Standards.People.rb to include a thermal comfort model option in space_type_apply_people
* split thermostats from space_type_apply_internal_load_schedules
Move thermostat creation by space type from space_type_apply_internal_load_schedules to space_type_apply_thermostat_schedules. This will keep consistency with prototype and NECB models.
For create_typical, use the new thermal_zones_set_thermostat_schedules method
* use PeopleDefinition object, not People
* Update thermostat_schedule_lookup.json
use older QSR thermostat setpoint schedules; newer ones have issues in parametric code
---------
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
* Reverting changes to DX heating coil naming
* Update regression test results to reflect changes to naming
---------
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
* Fixing typo (#2043)
* space type adjustments
* Fix #2044 - Remove Oniguruma Lookbehind with unicode matcher and similar constructs
* Nrcan 472c (#2046)
* Fixing typo
* Update regression tests based on adjustments to code.
* Nrcan 472c (#2050)
* Fixing typo
* Update regression tests based on adjustments to code.
* Upating HS14 costing test
* change 90_1_prm files back to master version
* rubocop fixes
* add create_typical_equipment method
- add gas and electric equipment space type jsons
- add create_typical_equipment method
- add test
* fix log reference
* move radiant system controls to hvac module
* change from Standard to HVAC module
* move transformers to equipment module
* change model_add_transformer to create_transformer
- edit code instances throughout
* Update refrigeration_compressors.csv
* Nrcan 472c (#2060)
* Updating dx coil changes to properly catch the DX coils with problems and make changes more efficient.
* Nrcan 478 (#2059)
* Including changes from master (#2033)
* HVAC components boiler
- move create_boiler_hot_water to module
- add tests for create_boiler_hot_water and create_hx_air_to_air_sensible_and_latent
* move create coil methods to HVAC module
* move create central air source heat pump method
* move create air conditioner vrf to HVAC module
* move HVAC conversions to HVAC module
* move create curve methods to HVAC module
- also change arguments to optional keyword arguments
* rename files by component
* consolidate and rename hx methods
* update component documentation grouping
* update log message locations
* add pump module
- move pump_variable_speed_set_control_type method to module
- move pump flow rate, power, etc. methods to module
- update HVAC code with new method locations
- add tests
* move template prototype pump methods to standards
* create helper methods module
- move methods from prototype utilities to helper methods module or other appropriate existing file
* fix reference
- load helper method module
- rename file to have rb extension
* Update central_air_source_heat_pump.rb
* move cooling coil capacity methods
* remove redundant headered pump coefficients method
remove redundant pump control type coefficients method for headered pumps as the coefficients and setter methods are the same for a variable speed pump. Add headered pumps as an input pump_variable_speed_set_control_type method.
* remove redundant fan files
* add missing module call
* move vrf get capacity method
air_conditioner_variable_refrigerant_flow_find_capacity -> air_conditioner_variable_refrigerant_flow_get_capacity
* capacity methods
move get capacity methods from Standards to the HVAC module
* capacity method for gas multi coils
* heating coil paired cooling capacity methods
* move air terminal reheat type method
* generalize paired cooling coil capacity method
* move coil_dx_heating_type method
* fix module method reference
* fix pump method call
* make individual hvac module component test files
* add tests for component capacity methods
* fan component refactor
* call module method create_fan_by_name
* fix create fan method names
* fix create fan method calls
* fix call to fan_variable_volume_set_control_type
* fix typos in method calls
* fix method call to coil capacity
* fix argument type and variable name errors
* fix name for fan curve type
* add create_fan_system_model method
Addresses #1521
* standards coil heating merge changes
* Update coil.rb
* missing module call
* set pressure rise for constant volume fans
Unit heaters were improperly excluded from having their pressure rise set. Also set a default in the data.
* fix logic for thermal zone check
* support unitary system in coil_dx_heat_pump?
- fixes #1954
- adds tests for coil methods
* Update coil.rb
* check for nil capacity before conversions
* prm hvac check fixes
- in prm baseline check, only add ptac to conditioned zones
- change PTAC fan type to constantvolume
* change fan type back to OnOff
* update regression models
* Update Prototype.hvac_systems.rb
method now in module
* Update test_performance_expected_dd_results.csv
* Renabling some tests and disabling some gems and require statements
* Updating covert_arg_to_bool to work as intended (#1993) (#1994)
* Re-enable some NREL tests
* create_typical_exterior_lighting method name
change model_create_typical_exterior_lighting to create_typical_exterior_lighting to align with other create methods
change model_get_exterior_lighting_properties to exterior_lighting_properties
* Nrcan 460 merge (#2000)
* data_update b8458b8
* change water temperatures to mixed temperatures
- Change water use temperatures to be the mixed water temperature. This is necessary because the faucet temps should be lower to account for heat loss in pipes and mixing. The 140F water use temps the same as the loop and water heater temps were causing issues with sizing. The loop rarely hit the target temperature.
- Mixed water temperatures changed from 140F to 110F for most use cases, 120F in kitchens for general use. Keep 180F for dishwashers.
- The prior flow rates and schedules seemed to be mixed water use, not hot water use. As an example, a 20,000 ft2 office with 1000 ft2 of bathrooms would have 5 EFLH * 0.02 gph per ft2 * 1000 ft2 = 100 gallons mixed water use, whereas 100 gallons of 140F would be to high. The overall values will need to be checked and updated.
* set water heater sizing properties
- set minimum loop temperatures of 125F for service water heating loops for legionella risk
- change the sizing loop delta temperature to larger values
- set water heater tank recovery times depending on fuel, and set sizing to PeakDraw
* Updating covert_arg_to_bool to work as intended
* Updating some files which were eroneously updated.
* fix coil eff application to necb models
The NECB PTAC / PTHP efficiency data doesn't have the 'application' field, causing the lookup to return nil, and the efficiency application to return false. Since the vars hash gets successively passed, further methods failing when trying to set variables on the now false hash.
Fixes are to return the original hash instead of false in the apply method. And to add a check to only apply the application search field for 90.1 templates.
* change necb models to new minimum loop temperature
* update expected regression results
* fix comstock pthp efficiency lookup
90.1-2004 and 90.1-2007 ASHRAE heat pump heating efficiencies use 'New Construction' and 'Replacements' as the application type, rather than 'Standard Size'. When the template includes ComStock , it uses the ASHRAE 90.1 databases but didn't strictly match the template type, so the efficiency lookup would fail.
* change swh loop temperature difference to 5K
change the service hot water loop design temperature difference back to 5 Kelvin (9 Rankine) from prior values. The prior changes were causing very low temperatures on booster hot water loops. And more typical design differences are 5-10R.
* Replacing openstudio-standards require statment with require_relative path to openstudio-standards.rb.
* updates regression models
* Update version.rb
* Updating test_run_costing_tests.rb to use initial set of building types.
---------
Co-authored-by: Xuechen (Jerry) Lei <xuechen.lei@pnnl.gov>
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
Co-authored-by: Landan Taylor <128543626+LandanT@users.noreply.github.com>
* Removing timings.json file and including it in .gitnore
* Updating btap_workflow.rb and removing README.md files.
* Revert "Re-enable some NREL tests"
This reverts commit 3795e76dbd995056f899a014620c88e6c6faa66f.
* Merge branch 'master' into hvac_component_refactor
* Update hvac_systems.rb
* update doe regression models
* Fix broken generate_userdata_to_csv
* update NRCAN regression tests
* Fix #2006 - Do not instantiate unique model objects
* Unrelated typo in a test helper
* fix incorrect model call to unmet hours check
* Showcase error with Ground PRM constructions
I think the culprit is this PR: https://github.com/NREL/openstudio-standards/pull/1903
```
[openstudio.model.Model] The run did not finish and had following errors: BuildingSurface:Detailed="SURFACE 19", invalid Outside Boundary Condition Construction="TYPICAL INSULATED CARPETED 6IN SLAB FLOOR" is not type Construction:FfactorGroundFloor.\nBuildingSurface:Detailed="SURFACE 1", invalid Outside Boundary Condition Construction="TYPICAL INSULATED CARPETED 6IN SLAB FLOOR" is not type Construction:FfactorGroundFloor.\nBuildingSurface:Detailed="SURFACE 37", invalid Outside Boundary Condition Construction="TYPICAL INSULATED CARPETED 6IN SLAB FLOOR" is not type Construction:FfactorGroundFloor.\nBuildingSurface:Detailed="SURFACE 25", invalid Outside Boundary Condition Construction="TYPICAL INSULATED CARPETED 6IN SLAB FLOOR" is not type Construction:FfactorGroundFloor.\nBuildingSurface:Detailed="SURFACE 7", invalid Outside Boundary Condition Construction="TYPICAL INSULATED CARPETED 6IN SLAB FLOOR" is not type Construction:FfactorGroundFloor.\nBuildingSurface:Detailed="SURFACE 43", invalid Outside Boundary Condition Construction="TYPICAL INSULATED CARPETED 6IN SLAB FLOOR" is not type Construction:FfactorGroundFloor.\nBuildingSurface:Detailed="SURFACE 31", invalid Outside Boundary Condition Construction="TYPICAL INSULATED CARPETED 6IN SLAB FLOOR" is not type Construction:FfactorGroundFloor.\nBuildingSurface:Detailed="SURFACE 13", invalid Outside Boundary Condition Construction="TYPICAL INSULATED CARPETED 6IN SLAB FLOOR" is not type Construction:FfactorGroundFloor.\nBuildingSurface:Detailed="SURFACE 49", invalid Outside Boundary Condition Construction="TYPICAL INSULATED CARPETED 6IN SLAB FLOOR" is not type Construction:FfactorGroundFloor.\nGetSurfaceData: Errors discovered, program terminates.
/home/julien/Software/Others/openstudio_gems/openstudio-standards-master/test/90_1_prm/create_performance_rating_method_helper.rb:193:in `create_baseline_model
```
* model_add_construction: catch the case were the construction name is found but isn't the right type
* Ensure we don't create a Ffactor / Cfactor construction if we have no construction_props to populate it
* Allow passing custom exclusiosn to log_messages_to_runner
* Flip a condition, cheaper to evaluate the bool first
* Make it a keywoard argument instead, and default to nil
* deep copy f and c factor constructions
- need to deep copy f and c factor constructions so they are specific to an individual surface. Right now it will potentially use the same F/C factor construction and edit values, even if used in another space.
- There is a distinction we don't account for in space vs. surface. The F/C factor values are derived from space lengths and areas, not surface areas and lengths.
* fix missing coil argument
* use necb unit tests from master
* fix necb unit test module method references
* return capacity if no cooling coil
In the coil_heating_get_paired_coil_cooling_capacity, if there is no cooling coil, return the capacity before check multiplier methods that depend on cooling coil.
* disable test_necb_reference_heatpump_rules
Disable test_necb_reference_heatpump_rules test for now. See comments on the hvac_component_refactor PR #1943 for detail.
* remove deep copy
* Update version.rb
* move btap costing testing to test directory
* Update necb_2011.rb
* add interior lighting module data, method, tests
* add prototype space type mapping
* Implementing new transfer manager method.
* Fix typo
* Removing comments
* Do not fail container if running on AWS
* Udptae comment
* Always failing container to see if btap_batch fix worked.
* update prototype space type mapping and tests
* rubocop and yard doc edits
* assert both methods return true in tests
- fix typo in SuperMarket model name
- assert that model_set_building_location and prototype_space_type_map both return true
* split ventilation section into new method
* use keyword args in space type apply methods
make space_type_apply_internal_loads and space_type_apply_internal_load_schedules arguments into keyword args instead of default args.
* only update ventilation if set_ventilation true
* add files to yard docs
* fix space_type_apply_internal_loads test
* split people from space type apply loads
split out the people section of space_type_apply_internal_loads into a separate section of code
* fix typo
* Update Gemfile.lock.3.9.0.
* Update insuite_central_doas_LargeHotel_one_sys_per_dwelling_unit_expected_results.json
Updating test results.
* inculding equality test
* Update unit test result to reflect airloop naming change (#2030)
* Removing code that deliberately breaks buildings with Electricity as the fuel type.
* Activating include statements (#2031)
* Include conditional failure report
---------
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
Co-authored-by: Xuechen (Jerry) Lei <xuechen.lei@pnnl.gov>
Co-authored-by: Landan Taylor <128543626+LandanT@users.noreply.github.com>
Co-authored-by: Julien Marrec <julien.marrec@gmail.com>
* Nrcan 472c (#2051)
* Merge master changes into nrcan_472c branch (#2038)
* remove college - and courthouse - prefixes
- remove the "College - " and "Courthouse - " prefixes to space type names. These are not necessary as they are already attached to a building type.
- add missing DEER space types from prototype_space_type_map
- fix some typos in prototype_space_type_map
* minor ci error fixes
- small office space name changed, b/c of overlap with space type name
- space type name update
---------
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
* Move test sql and osm files. Revert changes to non-NRCan code.
* Fixing paths. Resetting weather file path in file if the .osm weather file does not exist at the given path.
* Updating ci_tests.txt
* Update Gemfile.lock.3.9.0
* Updating 90.1 SmallOffice Regression tests
* Disabling caching by default but still retaining the functionality to use it if desired.
* Moved and renamed the test helper since it's not a test
* Reverting SmallOffice OSM files from master
* Removing automatic caching of OSM and SQL files
* Update with changes from master. (#2041)
* remove college - and courthouse - prefixes
- remove the "College - " and "Courthouse - " prefixes to space type names. These are not necessary as they are already attached to a building type.
- add missing DEER space types from prototype_space_type_map
- fix some typos in prototype_space_type_map
* rename thermal_zone_add_unconditioned_thermostat
- rename thermal_zone_add_unconditioned_thermostat to thermal_zone_set_unconditioned_thermostat
- fix cooling schedule name
* rename thermal_zone module file
rename to information to match other modules. All methods are to get thermal zone information
* move thermal_zone_set_unconditioned_thermostat
move thermal_zone_set_unconditioned_thermostat to new thermostat_schedules file to contain all thermostat schedule methods for thermal zones
* method and data for thermostat schedule lookup
Use the ComStock templates to generate a thermostat_schedule_lookup.json.
The thermostat schedules will be attached to space types, with variation by building type.
The ComStock template will disappear soon; this commit is a log of how the thermostat schedule_lookup was generated, using the templates as they existed in openstudio-standards. (0.8.4, with edits to support incomplete space types. Possibly 0.8.5 - see commits around this time.).
* log message notation update
* rename test_thermal_zone to test_thermal_zone_information
* minor ci error fixes
- small office space name changed, b/c of overlap with space type name
- space type name update
* add method to set zone thermostats
add thermal_zones_set_thermostat_schedules method, which pulls from the thermostat_schedule_lookup json to set thermostats depending on the zone standards space type and building type
* Add thermal comfort model options
Update Standards.People.rb to include a thermal comfort model option in space_type_apply_people
* split thermostats from space_type_apply_internal_load_schedules
Move thermostat creation by space type from space_type_apply_internal_load_schedules to space_type_apply_thermostat_schedules. This will keep consistency with prototype and NECB models.
For create_typical, use the new thermal_zones_set_thermostat_schedules method
* use PeopleDefinition object, not People
* Update thermostat_schedule_lookup.json
use older QSR thermostat setpoint schedules; newer ones have issues in parametric code
---------
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
* Reverting changes to DX heating coil naming
* Update regression test results to reflect changes to naming
* Including SEER in DX single speed heating coil options.
* Removing debug comments.
* Fixing typo
* Update regression tests based on adjustments to code.
* Upating HS14 costing test
---------
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
Co-authored-by: Nicholas Pneumaticos <nicholaspneu@gmail.com>
* Changed test class names so they're able to be run in the parallel test suite
* Removing comments associated with caching
---------
Co-authored-by: Chris Kirney <36897585+ckirney@users.noreply.github.com>
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
Co-authored-by: Xuechen (Jerry) Lei <xuechen.lei@pnnl.gov>
Co-authored-by: Landan Taylor <128543626+LandanT@users.noreply.github.com>
Co-authored-by: Julien Marrec <julien.marrec@gmail.com>
Co-authored-by: Chris Kirney <chris.kirney@canada.ca>
---------
Co-authored-by: nicholas9901 <155596194+nicholas9901@users.noreply.github.com>
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
Co-authored-by: Xuechen (Jerry) Lei <xuechen.lei@pnnl.gov>
Co-authored-by: Landan Taylor <128543626+LandanT@users.noreply.github.com>
Co-authored-by: Julien Marrec <julien.marrec@gmail.com>
* Enable require statements disabled in master.
---------
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
Co-authored-by: Xuechen (Jerry) Lei <xuechen.lei@pnnl.gov>
Co-authored-by: Jeremy L. <5149279+lymereJ@users.noreply.github.com>
Co-authored-by: Nicholas Pneumaticos <nicholaspneu@gmail.com>
Co-authored-by: Julien Marrec <julien.marrec@gmail.com>
Co-authored-by: nicholas9901 <155596194+nicholas9901@users.noreply.github.com>
Co-authored-by: Landan Taylor <128543626+LandanT@users.noreply.github.com>
* update necb regression tests
* update necb regressions
these changes impacted dx cooling cop for some reason; unclear why
* Update version.rb
* use schedule for ext lights
use schedule with setback instead of astronomical clock
* use HVAC component module methods
- get rid of deprecated methods in necb HVAC
- use hvac component module methods instead
- change air_conditioner_variable_refrigerant_flow_get_capacity to air_conditioner_variable_refrigerant_flow_get_cooling_capacity
- add air_conditioner_variable_refrigerant_flow_get_heating_capacity
* remove version tag in expected results
regression tests should not have a version tag; only use in debugging, as every version change will trigger a regression error.
* disable btap costing regressions
The method def evaluate_regression_files(test_instance:, cost_result:) does a direct file compare, which throughs errors depending on how empty arrays are formatted from JSON.pretty_generate. As there is not an argument to set how empty arrays should be set, and different systems produce it differently, I'm disabling the tests for now.
The method should load the jsons and compare objects, not raw files.
* Update hvac_systems.rb
check autosized condition, and set capacity as the old method did
* add DEER service water assumptions
using the existing DEER data in openstudio-standards; no attempt at reconciliation of differences between typical service water with ASHRAE prototypes
* Update btap_datapoint.rb to enable aws require statements in btap_datapoint.rb
* Update btap_datapoint.rb require statemets
* Update openstudio-standards.gemspec to install additional gems
* Updating Gemfile.lock.3.9.0 file
* setDoPlantSizingCalculation only if SizingPlant objects
EnergyPlus version 25.2 errors out if Plant Sizing is set to true in the simulation control object, but the model has no Sizing:Plant objects. https://github.com/NREL/EnergyPlus/pull/11140
In model_run_sizing_run, do plant sizing if and only if there are Sizing:Plant objects in the model.
* Update version.rb
* clean up climate zone value getters/setters
* Update Gemfile
---------
Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com>
Co-authored-by: Xuechen (Jerry) Lei <xuechen.lei@pnnl.gov>
Co-authored-by: Jeremy L. <5149279+lymereJ@users.noreply.github.com>
Co-authored-by: Nicholas Pneumaticos <nicholaspneu@gmail.com>
Co-authored-by: Julien Marrec <julien.marrec@gmail.com>
Co-authored-by: nicholas9901 <155596194+nicholas9901@users.noreply.github.com>
Co-authored-by: Landan Taylor <128543626+LandanT@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Description of the purpose of this PR
It was noticed that when in the SimulationControl object that a user says "Yes" for the Do HVAC Sizing Simulation for Sizing Periods field without having any Sizing:Plant objects in the input that a hard crash results which is undesirable.
Now, when the user sets this field to "Yes" without any Sizing:Plant objects, one of two things happen. If the Do Plant Sizing Calculation field is set to "No", this overrides the user input for Do HVAC Sizing Simulation for Sizing Periods field and a warning error is produced. If the Do Plant Sizing Calculation field is set to "Yes", EnergyPlus will produce a severe/error warning stating that at least one Sizing:Plant object must be entered or these fields should both be set to "No".
A new unit test verifying the correct severe/fatal error is being produced under the correct conditions (both "Yes" and no Sizing:Plant objects). In addition, the description of the Do HVAC Sizing Simulation for Sizing Periods field was enhanced in the Input Output Reference so that it is clear what is required of the user.
Pull Request Author
Reviewer