Pull request overview

• Fixes User file crashes with ZoneControl:Thermostat but no ThermostatSetpoint:* objects #11122

Description of the purpose of this PR

A user file had a ZoneControl:Thermostat object which referred to a ThermostatSetpoint:* object that did not exist anywhere in the input file. As a result, the find index came back as zero which led to a hard crash due to an improper array index. The fix traps when this happens and issues a severe/fatal error describing what is wrong/what to fix while avoiding the hard crash. A unit test demonstrates this input situation and properly shows that this situation leads to the new error message. No differences are expected in the output since this fixes a bug that caused a hard crash and no files in the test suite actually crash.

Pull Request Author

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs