Correct Missing Information in Exterior Fenestration Shaded State Table#11118
Correct Missing Information in Exterior Fenestration Shaded State Table#11118
Conversation
This corrects the issue where the exterior fenestration shading state report is not producing output for valid window shading control input. Before this report was only being populated for windows that had a frame or divider. Now, shading control for windows without frames/dividers will also be listed in this predefined report.
Creation of a unit test to fix the issue with a report that was missing. Plus a typo correction in a comment of the fix.
Minor tweaks and corrections to the IO Ref relating to the fix made here. This clarifies what will be reported and when. Also a few minor edits were made for consistency.
|
mjwitte
left a comment
There was a problem hiding this comment.
Tested with WindowTests.idf. The table is populated now, but the U-Factor and SHGC values are identical to the unshaded construction. VT does vary.
The values reported in the exterior fenestration shaded state table were not correct as they were using the unmodified glass values. This has been corrected. Modification to the unit test was also necessary.
@mjwitte I have fixed this in the latest commit that I just made. I believe that the report should be correct now. The unit test also had to be updated to reflect this change. |
|
|
Hmm. I made a test file that adds a skinny frame to all the windows in Windowtests. The new reported values for shaded glass SHGC and VT agree with the value with a frame (same for develop and this branch). But the shaded SHGC looks wrong (both with frame and without). You can look into that here, or make a new issue for that, or prove me wrong. It just seems impossible the the glass SHGC for Double Pane with Drapes is 0.746 when the unshaded SHGC is 0.764 and the assembly SHGC is 0.077. |
|
@mjwitte I guess I am still somewhat uncertain as to what specifically this table is trying to show. Are the "Glass" values supposed to be the "unshaded" (only glass without the shading element) values or something else? In other words, are the glass values for the DP with screen supposed to be the values for the glass only without a screen and then the assembly values for everything including the screen? Initially, I thought that was the case, but now I'm unsure what this report is trying to show. What I can say is that right now, the values being reported for "Glass" are the same for no frame and divider and when the skinny frame/divider is present other than a minor adjustment to the U-value. In other words, the code now is doing the same thing for this report whether there is a frame/divider or not which is an improvement. Whether the code is actually producing/reporting the correct value is a different mater. I don't disagree with what you wrote, but I'm also not sure In know the answer. I think I'm more leaning towards someone who has more knowledge about the window code to take a look at this in a separate issue. Do you have any additional thoughts? Do we have anyone on the team currently who has expertise in this area that could speak to what the values should be? |
It should be the shaded glazing without any allowance for the frame. I'll just post a new issue for this.; |
…ngInfoExtFenestrationShadeTable
|
|
@RKStrand I think I see the problem with the shaded SHGC values. I'm going to try to fix that in this same PR. |
…ngInfoExtFenestrationShadeTable
|
@mjwitte Cool--hope that isn't much of a time commitment... |
|
|
@mjwitte Just trying to clarify, are you asking that reporting for unframed shaded windows also be sent to the EIO? |
Yes, please, if it's not too much trouble. |
|
@mjwitte Thanks for clarifying. I'll look into it and get back to you. I don't think it should be too much trouble but of course I could always be wrong here. |
The information that was added to the HTML tabular report was not reporting to the EIO like it does for windows with frames/dividers. This corrects this issue and now reports to the EIO.
|
@mjwitte I have just made a commit that has the windows without frames/dividers print out the information to the EIO as you requested. Let me know if this looks good or if there's still something to be done here. Assuming that this passes all the tests as I just added something to the EIO and it did work as anticipated for WindowTest.idf. |
|
|
@RKStrand Thanks for adding the eio output, but it was writing the same construction multiple times. I added a check to avoid duplication and noticed that the check for shaded constructions with frames could be moved up to avoid duplicate writes to the predefined report. Let's see how CI likes this. |
|
|
Here's an example of the new eio lines for WindowTests.idf: |
|
@Myoldmopar Assigning this to you for final review and merge. |
|
@Myoldmopar @RKStrand @Myoldmopar it has been 36 days since this pull request was last updated. |
|
|
Pull request overview
Description of the purpose of this PR
The Exterior Fenestration Shaded State Table produces information about windows when shading control is implemented by the user. The problem is that when a window without a frame/divider is entered, nothing is shown in this table. The fix here is to produce values in this table for windows whether or not the window has a frame/divider when shading control is requested by the user. When a frame/divider exists, the table will report as before. Without a frame divider, the table will now as a result of this fix show values relating to the U-Factor, SHGC, and visible transmittance for the glass only in the shaded state. This includes a unit test to verify that this is reporting properly and fixes to the documentation (Input Output Reference) to clarify what will be reported.
Expected Diffs
FenestrationShadedStatefor shaded constructions used without a frame/divider.Pull Request Author
Reviewer