[test] revert: Remove Step 3.7 Flash tests#4053
Merged
Merged
Conversation
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Contributor
|
LGTM - clean test removal with no dangling references. Suggested test cases: No perf tests impacted. |
Contributor
|
Detailed review: The PR removes all 11 Step-3.7 Flash unit test files (8 data/vlm_datasets tests, 2 models/stepfun tests, 1 init). The implementation under src/ is preserved. Verified no remaining step37 references in tests/ (surviving stepfun refs are for Step-3.5). No dangling imports or conftest entries. One note: this removes ~690 lines of unit test coverage for Step-3.7 data utilities and model config/embedding logic. The follow-up to reintroduce tests should be tracked to avoid a lasting coverage gap. |
vasunvidia
pushed a commit
to vasunvidia/Megatron-Bridge
that referenced
this pull request
Jun 10, 2026
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com> Signed-off-by: Vasudevan Rengasamy <vrengasamy@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
tests/functional_tests.tests/functional_testsand found no Step-3.7-specific functional test references to remove.Validation
grep -RInE 'step37|Step-3.7|Step 3.7|Step3.7|stepfun-ai/Step-3.7' tests/unit_tests tests/functional_testsreturns no matches.git diff --cached --checkpassed before commit.uv run --no-sync pre-commit run --all-filespassed.