Safely clean up recent upstreamed code#3988
Merged
Merged
Conversation
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
maanug-nv
commented
May 27, 2026
| """Restore ModelOpt quantization/sparsity state.""" | ||
|
|
||
| # === HuggingFace Metadata === | ||
| hf_model_id: str | None = None |
Contributor
Author
There was a problem hiding this comment.
note, these HuggingFace specific fields are no longer available and are replaced by extra_checkpoint_metadata.
When migrating the conversion bridges to use configs based on this class (GPTModelConfig, HybridModelConfig, etc., replacing the providers), the hf_model_id should be read and written from extra_checkpoint_metadata dict. Should confirm that this gets serialized to/deserialized from the checkpoint so that it doesn't break users, eg export+deploy.
cc @yaoyu-33
yaoyu-33
previously approved these changes
May 27, 2026
Signed-off-by: Maanu Grover <maanug@nvidia.com>
cuichenx
approved these changes
May 29, 2026
erictang000
added a commit
to NovaSky-AI/SkyRL
that referenced
this pull request
Jun 9, 2026
…ron-bridge to latest (#1762) This PR makes the following bumps megatron_core from `cefc2520158c7ceba3f9adbe4b547a6f7a118da1` (latest dev branch as of 6/8/26) to `71e418ea7d7b3a6c9a53238c543c3e0b43e11026` (latest main branch as of 6/8/26. megatron-bridge from `8382dc343b07b068a827ca20bae860633df3baa0` to `91a15142a4b4442a8d46ab539d1b923bd08570d0` (latest main 6/8) Megatron-Bridge has upstreamed code to the main branch that isn't on the dev branch that is needed to use Megatron-Bridge (NVIDIA-NeMo/Megatron-Bridge#3988) Since sequence packing with GDN is now supported on main, we can move back over to the latest commit on the main branch: NVIDIA/Megatron-LM#2645
vasunvidia
pushed a commit
to vasunvidia/Megatron-Bridge
that referenced
this pull request
Jun 10, 2026
Signed-off-by: Maanu Grover <maanug@nvidia.com> Signed-off-by: Vasudevan Rengasamy <vrengasamy@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Import, delete, and re-export utils, functions, classes that were recently upstreamed to MLM.
Changelog
GitHub Actions CI
See the CI section in the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information