[docs] Move diffusion model examples#3901
Merged
Merged
Conversation
Signed-off-by: Chen Cui <chcui@nvidia.com>
Contributor
|
LGTM — clean file move with consistent path updates across docs, examples, and tests. No stale references to the old examples/diffusion/models/ path remain. One pre-existing note (not introduced by this PR): examples/models/wan/README-perf-test.md lines 69 and 105 reference examples/models/wan/pretrain_wan.py, which does not exist (it did not exist at the old path either). Worth a follow-up cleanup. Suggested test cases: No perf tests impacted. The only perf config change (wan_workload_base_configs.py) is a docstring-only edit with no functional effect. The following existing functional tests should be run to confirm the moved conversion scripts are found at their new paths:
|
yaoyu-33
approved these changes
May 21, 2026
huvunvidia
approved these changes
May 22, 2026
huvunvidia
left a comment
Contributor
There was a problem hiding this comment.
Looks reasonable. Thank you!
vasunvidia
pushed a commit
to vasunvidia/Megatron-Bridge
that referenced
this pull request
Jun 10, 2026
Signed-off-by: Chen Cui <chcui@nvidia.com> Signed-off-by: Vasudevan Rengasamy <vrengasamy@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/diffusion/modelstoexamples/models.Validation
examples/diffusion/models,diffusion/models/(flux|wan),examples.diffusion.models, andexamples/models/wan/confreturned no hits.python3 -m py_compilepassed for moved Flux/Wan Python examples plus touched Wan performance config and conversion functional tests.git diff --checkpassed.uv tool run ruff check ...passed.uv tool run ruff format --check ...passed.uv run pre-commit run --all-fileswas attempted but blocked on this host because lockednvidia-resiliency-ext==0.6.0only hasmanylinux_2_39wheels while the host resolves asmanylinux_2_31_x86_64.Blast Radius / Test Tier