feat: Implement dynamic position embedding type#2768
Merged
Conversation
Megatron models based on hf_config; remove hardcoded 'rope' setting from various model bridge s. Signed-off-by: ruit <ruit@nvidia.com>
cuichenx
reviewed
Mar 12, 2026
| # Llama-specific Megatron defaults | ||
| provider.normalization = "RMSNorm" | ||
| provider.gated_linear_unit = True | ||
| provider.position_embedding_type = "rope" |
Contributor
There was a problem hiding this comment.
https://huggingface.co/meta-llama/Llama-3.1-70B-Instruct/blob/main/config.json
Llama 3 has rope_type = "llama3". so we might need to keep this in llama bridge?
Contributor
Author
There was a problem hiding this comment.
I think it's OK here.
- I think code in here can handle the situation. If the
rope_scalingis set in model config, we will use it directly. If we leave this line out, it will force the use ofrope. - LLama has special rope_scaling handle logic here. So this line doesn't matter.
yaoyu-33
pushed a commit
that referenced
this pull request
Mar 12, 2026
Signed-off-by: ruit <ruit@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Megatron models based on hf_config; remove hardcoded 'rope' setting from various model bridge s.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Changelog
GitHub Actions CI
See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information