ci: fix Fern devnotes artifact lookup#667
Conversation
Greptile SummaryThis PR fixes the post-merge
|
| Filename | Overview |
|---|---|
| .github/workflows/publish-fern-devnotes.yml | Adds --repo "$GITHUB_REPOSITORY" to gh run list and gh run download in the notebook artifact lookup step so repo inference works when the step runs outside a git checkout directory. |
Sequence Diagram
sequenceDiagram
participant GHA as GitHub Actions Runner
participant GH as gh CLI
participant API as GitHub API
GHA->>GH: gh run list --repo "$GITHUB_REPOSITORY" --workflow "build-fern-docs.yml" --status success --event release
GH->>API: GET /repos/NVIDIA-NeMo/DataDesigner/actions/workflows/.../runs
API-->>GH: "[{ databaseId: 12345, ... }]"
GH-->>GHA: "last_run_id=12345"
GHA->>GH: gh run download 12345 --repo "$GITHUB_REPOSITORY" --name notebooks --dir website/docs/notebooks
GH->>API: GET /repos/NVIDIA-NeMo/DataDesigner/actions/runs/12345/artifacts
API-->>GH: notebooks artifact
GH-->>GHA: artifact downloaded → exit 0
Reviews (1): Last reviewed commit: "ci: fix Fern devnotes artifact lookup" | Re-trigger Greptile
Code Review: PR #667 — ci: fix Fern devnotes artifact lookupSummaryTwo-line fix to FindingsCorrectness
Style & Conventions
Risk / Blast Radius
Test Coverage
Security
Suggestions (non-blocking)
VerdictApprove. The change is minimal, correct, addresses the documented post-merge failure, and carries effectively zero risk to the rest of the codebase. Manual verification is appropriate given the workflow-only scope. |
📋 Summary
Fixes the post-merge
Publish Fern devnotesfailure by making the notebook artifact lookup explicit about which repository to query. After the Fern publishing change, this workflow runsghfrom the Actions workspace root rather than a checkout, so repo inference no longer works.🔗 Related Issue
N/A. Follow-up to failed workflow run https://github.com/NVIDIA-NeMo/DataDesigner/actions/runs/25939020504.
🔄 Changes
--repo "$GITHUB_REPOSITORY"to thegh run listnotebook lookup.--repo "$GITHUB_REPOSITORY"to the matchinggh run downloadartifact fetch.🧪 Testing
gh run listcommand from/tmpwithGITHUB_REPOSITORY=NVIDIA-NeMo/DataDesigner.gh run downloadcommand downloads thenotebooksartifact from the latest successful release docs run./home/ubuntu/Code/repos/DataDesigner/checkouts/main/.venv/bin/ruff check --fix ./home/ubuntu/Code/repos/DataDesigner/checkouts/main/.venv/bin/ruff format .make testnot run - workflow-only fix.✅ Checklist