You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Updates the default nvidia-vision model alias from nvidia/nemotron-nano-12b-v2-vl to nvidia/nemotron-3-nano-omni-30b-a3b-reasoning, which provides improved multimodal capabilities with reasoning support.
We're keeping the openrouter-vision model config unchanged until nvidia/nemotron-nano-12b-v2-vl becomes available there.
Updated PREDEFINED_PROVIDERS_MODEL_MAP[nvidia][vision] to use nvidia/nemotron-3-nano-omni-30b-a3b-reasoning with new inference params (temperature=0.60, top_p=0.95)
Added NEMOTRON_3_NANO_OMNI_30B_A3B_REASONING_INFERENCE_PARAMS constant in constants.py
Updates the default nvidia-vision model alias from nvidia/nemotron-nano-12b-v2-vl to nvidia/nemotron-3-nano-omni-30b-a3b-reasoning and adjusts inference parameters (temperature lowered from 0.85 to 0.60). Changes are consistently reflected across the constants file, documentation, and test assertions.
Confidence Score: 5/5
This PR is safe to merge — changes are config/constant updates with no logic errors and all dependent files updated consistently.
No P0 or P1 issues found. The model name, inference params, docs, and test assertions are all updated in lockstep. The lower temperature (0.60) is appropriate for a reasoning-capable model.
Adds NEMOTRON_3_NANO_OMNI_30B_A3B_REASONING_INFERENCE_PARAMS constant and updates PREDEFINED_PROVIDERS_MODEL_MAP vision entry to use the new model and params; consistent with the pattern of other named-model param constants.
nabinchha
changed the title
feat: update default nvidia-vision model to nemotron-3-nano-omni-30b-a3b-reasoning
feat: update default nvidia-vision model to nemotron-3-nano-omni
Apr 28, 2026
Review: PR #583 — feat: update default nvidia-vision model to nemotron-3-nano-omni-30b-a3b-reasoning
Summary
Small, focused config-only change that re-points the nvidia-vision alias in PREDEFINED_PROVIDERS_MODEL_MAP from nvidia/nemotron-nano-12b-v2-vl to nvidia/nemotron-3-nano-omni-30b-a3b-reasoning, tuned with temperature=0.60, top_p=0.95. A new NEMOTRON_3_NANO_OMNI_30B_A3B_REASONING_INFERENCE_PARAMS constant is introduced, and docs + one test assertion are updated to match. 4 files, +8/-4.
Findings
Correctness
Only the nvidia provider entry is updated; openrouter-vision is intentionally left on the old model. Confirmed via constants.py:378 in the PR branch — openrouter still references nvidia/nemotron-nano-12b-v2-vl with DEFAULT_VISION_INFERENCE_PARAMS. That is why DEFAULT_VISION_INFERENCE_PARAMS remains (correctly) defined. The test builtin_model_configs[10] at line 90 of test_default_model_settings.py still asserts the old name, which is consistent. Worth confirming in the PR description that the openrouter asymmetry is deliberate — the PR title and summary say "update default nvidia-vision model" which reads cleanly, but a reader skimming the diff may wonder whether the openrouter entry was overlooked.
New model name advertises "reasoning" but no reasoning_effort is set. Every other "reasoning" model in this file (nemotron-3-super-120b-a12b, gpt-5) passes extra_body={"reasoning_effort": "medium"}. If nemotron-3-nano-omni-30b-a3b-reasoning supports the same knob, omitting it is a silent behavioral divergence; if it doesn't, a one-line comment here would pre-empt the obvious reviewer question. Please confirm with the model card.
Test coverage
test_get_builtin_model_configs asserts the new model string but does not assert the new inference parameters (temperature=0.60, top_p=0.95). The inference params are half of what this PR changes — an accidental reversion to the old values would pass tests today. Recommend adding assert builtin_model_configs[2].inference_parameters.temperature == 0.60 and top_p == 0.95 (or asserting the full dict against the new constant) alongside the existing model-name assertion. Low-cost, high-signal.
The placement of the new constant next to the other model-specific constant blocks is correct.
No changes needed to imports, types, or __future__ annotations. No ruff-relevant surface touched.
Docs
default-model-settings.md row for nvidia-vision is updated. Good.
model-configs.md swaps the model string in the example but leaves the example's temperature=0.7, top_p=0.95, max_tokens=2048 unchanged. That's fine — it's an example of custom config, not a canonical default, and the values there have always differed from the real default. No action needed, just flagging for awareness.
Stale reference: docs/devnotes/posts/assets/data-designer-got-skills/trace-skill.html:169 still shows nvidia-vision nvidia/nemotron-nano-12b-v2-vl. This looks like a captured trace artifact from a historical run, so it's reasonable to leave it as-is (trace outputs rot naturally), but worth a one-line mention in the PR if you want to be explicit that it was seen and intentionally skipped.
Performance / Security
Nothing to flag. Pure config change; no new imports, no network code, no secrets surface.
Verdict
Approve with two small asks (both optional, neither blocking):
Extend test_get_builtin_model_configs to also assert the new temperature/top_p values so the inference-params half of this change is covered.
In the PR description (or a brief inline comment), confirm the reasoning_effort omission is intentional given the new model's "reasoning" suffix, and note that openrouter-vision is deliberately left on the previous model.
Change itself is low-risk, well-scoped, and follows established patterns in constants.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
Updates the default
nvidia-visionmodel alias fromnvidia/nemotron-nano-12b-v2-vltonvidia/nemotron-3-nano-omni-30b-a3b-reasoning, which provides improved multimodal capabilities with reasoning support.We're keeping the
openrouter-visionmodel config unchanged untilnvidia/nemotron-nano-12b-v2-vlbecomes available there.🔗 Related Issue
Closes #582
🔄 Changes
PREDEFINED_PROVIDERS_MODEL_MAP[nvidia][vision]to usenvidia/nemotron-3-nano-omni-30b-a3b-reasoningwith new inference params (temperature=0.60, top_p=0.95)NEMOTRON_3_NANO_OMNI_30B_A3B_REASONING_INFERENCE_PARAMSconstant inconstants.pydefault-model-settings.mdandmodel-configs.md🧪 Testing
make testpassestest_default_model_settings.py✅ Checklist
Made with Cursor