fix: Propagate torch_dtype to sub-configs correctly#2027
Merged
Conversation
Signed-off-by: Abhishree Thittenamane <athittenaman@cw-dfw-cs-001-login-02.cm.cluster>
Contributor
Author
|
/claude review |
Contributor
Author
|
/ok to test 6de0c36 |
HuiyingLi
approved these changes
Apr 23, 2026
kashif
pushed a commit
to kashif/Automodel
that referenced
this pull request
May 25, 2026
Propagate torch_dtype to sub-configs correctly Signed-off-by: Abhishree Thittenamane <athittenaman@cw-dfw-cs-001-login-02.cm.cluster> Co-authored-by: Abhishree Thittenamane <athittenaman@cw-dfw-cs-001-login-02.cm.cluster>
yuekaizhang
added a commit
to yuekaizhang/RL
that referenced
this pull request
Jun 2, 2026
…o#2027) Repin the Automodel submodule from 26108096 to 6eb5e862 ("fix: Propagate torch_dtype to sub-configs correctly", from NVIDIA-NeMo/Automodel#2027) as a temporary pin. Note: 6eb5e862 is an unmerged PR commit (an older force-pushed revision of NVIDIA-NeMo#2027, not its current head and not on main) and predates the Nemotron-Omni RADIO post-load patches in 26108096. It still pins transformers==5.5.0 in its own metadata, so the transformers override stays consistent. The refreshed uv.lock reflects the reverse-delta (drops the later s3 / msc extras and the wandb>=0.26.1 pin). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: root <zhangyuekai@foxmail.com>
yuekaizhang
added a commit
to yuekaizhang/RL
that referenced
this pull request
Jun 2, 2026
Bump the Automodel submodule to 5dcc9abe9 ("fix: Propagate torch_dtype to
sub-configs correctly", NVIDIA-NeMo/Automodel#2027). This is the oldest
commit on Automodel main that carries the NVIDIA-NeMo#2027 torch_dtype-propagation
fix, so it is reachable by a plain `git submodule update` (unlike the
orphaned, force-pushed PR-head revision of the same change, which lives in
Automodel's pre-rewrite history and is on no upstream branch).
It pins transformers==5.5.0 in its own metadata, keeping the transformers
override consistent. uv.lock refreshed accordingly.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: root <zhangyuekai@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fixes #2017.
Verified by running
examples/vlm_finetune/gemma4/gemma4_4b_mock.yamlwithtorch_dtype: torch.float32and dont see the error mentioned in the issue anymore.Changelog
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information