Update example notebooks to create schema object from merlin core#650
Merged
bschifferer merged 6 commits intomainfrom Mar 17, 2023
Merged
Update example notebooks to create schema object from merlin core#650bschifferer merged 6 commits intomainfrom
bschifferer merged 6 commits intomainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Documentation previewhttps://nvidia-merlin.github.io/Transformers4Rec/review/pr-650 |
bschifferer
reviewed
Mar 16, 2023
| @@ -69,7 +69,18 @@ | |||
| "execution_count": 2, | |||
Contributor
There was a problem hiding this comment.
I think we call fit transform twice - first above - .fit and .transform and then .compute
and here, we call workflow.fir_transform().to_parquet.
We do the calculation twice.
I think we should change the process above to all fit_transform().to_parquet and then read the data with cudf.read_parquet() here.
Reply via ReviewNB
Contributor
Author
There was a problem hiding this comment.
sure. I can change that.
bschifferer
approved these changes
Mar 16, 2023
Contributor
bschifferer
left a comment
There was a problem hiding this comment.
I approve, if we change the NVTabular workflow to fit/transform only once instead of doing it twice
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates schema creation line in the example notebooks based on this merged PR #642.
Blocked by the error coming from multi gpu training example: #651