Allow Schema class from core to be used to create Trainer#642
Merged
marcromeyn merged 5 commits intomainfrom Mar 15, 2023
Merged
Allow Schema class from core to be used to create Trainer#642marcromeyn merged 5 commits intomainfrom
marcromeyn merged 5 commits intomainfrom
Conversation
… with core-schema out to a separate test
Documentation previewhttps://nvidia-merlin.github.io/Transformers4Rec/review/pr-642 |
nv-alaiacano
approved these changes
Mar 14, 2023
rnyak
reviewed
Mar 14, 2023
oliverholworthy
approved these changes
Mar 15, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals ⚽
This PR adds some testing to ensure the merlin-core Schema could be used to instantiate a
Trainerobject.