Skip to content

Fetch release branches so that we can figure out the release branch#609

Merged
oliverholworthy merged 1 commit intoNVIDIA-Merlin:mainfrom
oliverholworthy:tag-build-fetch-release-branches
Feb 3, 2023
Merged

Fetch release branches so that we can figure out the release branch#609
oliverholworthy merged 1 commit intoNVIDIA-Merlin:mainfrom
oliverholworthy:tag-build-fetch-release-branches

Conversation

@oliverholworthy
Copy link
Copy Markdown
Contributor

@oliverholworthy oliverholworthy commented Feb 3, 2023

Follow-up to #608

Adds a fetch of the release branches so that we can figure out the release branch name that the tag corresponds to. This is required because the default checkout behaviour of the actions/checkout step is to fetch only the single commit without any branch names.

An alternative to this is to specify fetch-depth: 0 on the actions/checkout step which will result in a full fetch of all commits, branches, and tags. However, that is slightly slower due to it fetching everything instead of the more minimal set of commit data. And would apply to every build the way it's setup now and not only for the publish.

@oliverholworthy oliverholworthy added this to the Merlin 23.02 milestone Feb 3, 2023
@oliverholworthy oliverholworthy self-assigned this Feb 3, 2023
@oliverholworthy oliverholworthy merged commit ae5f305 into NVIDIA-Merlin:main Feb 3, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 3, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants