Update branch name extraction for tag builds#608
Merged
oliverholworthy merged 2 commits intoNVIDIA-Merlin:mainfrom Feb 3, 2023
Merged
Update branch name extraction for tag builds#608oliverholworthy merged 2 commits intoNVIDIA-Merlin:mainfrom
oliverholworthy merged 2 commits intoNVIDIA-Merlin:mainfrom
Conversation
Documentation previewhttps://nvidia-merlin.github.io/Transformers4Rec/review/pr-608 |
jperez999
approved these changes
Feb 3, 2023
oliverholworthy
added a commit
that referenced
this pull request
Feb 3, 2023
* Remove leading whitespace from branch name in workflow for tag build * Filter branches and specify format when using git branch in workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git branch -r --contains v0.1.16, for example, returnsorigin/release-22.12. The subsequent line in our workflow failed to remove the prefixorigin/because if doesn't currently handle this whitespace.--format "%(refname:short)"to ensure we only get the branch name and not leading whitespace--list '*release*'to ensure we select the release branch name. There is still an edge case where we could have the tag pointing at multiple release branches, but that seem less likely to happen.