Followup for null count fixup in row_conversion.cu.#1155
Merged
mythrocks merged 4 commits intoNVIDIA:branch-23.06from May 23, 2023
Merged
Followup for null count fixup in row_conversion.cu.#1155mythrocks merged 4 commits intoNVIDIA:branch-23.06from
mythrocks merged 4 commits intoNVIDIA:branch-23.06from
Conversation
Collaborator
Author
|
Build |
ttnghia
reviewed
May 21, 2023
ttnghia
reviewed
May 21, 2023
ttnghia
reviewed
May 21, 2023
This is a followup to NVIDIA#1148. `row_conversion.cu` was modified in rapidsai/cudf#13372 to explicitly calculate null-counts for output columns. This commit replicates the changes in cudf/pull/13372, and adds explicit null-count calculation for the string offsets column. Signed-off-by: MithunR <mythrocks@gmail.com>
5d3351b to
ac31cce
Compare
Signed-off-by: MithunR <mythrocks@gmail.com>
ttnghia
reviewed
May 23, 2023
Collaborator
Author
|
Build |
hyperbolic2346
approved these changes
May 23, 2023
Collaborator
hyperbolic2346
left a comment
There was a problem hiding this comment.
This code is dense, but I believe this to be correct. The computed columns have null masks if incoming data has null masks, but there is no null count, so doing this work seems appropriate.
Collaborator
Author
|
Thanks for reviewing, @hyperbolic2346. I'm ready to merge this. Edit: @ttnghia, the only pending issue is |
mythrocks
added a commit
to mythrocks/spark-rapids-jni
that referenced
this pull request
May 25, 2023
Fixes NVIDIA#1169. This commit fixes the null counts in row/column conversion, for all output columns. The prior fix in NVIDIA#1155 only fixed the count for STRING outputs. There are 2 additional/tangential fixes in this change: 1. `cudf::detail::null_count()` is used in place of `cudf::null_count()`, thus running on the current stream. 2. The Java `RowConversion.convertFromRowsFixedWidthOptimized()` now uses the `convertFromRowsFixedWidthOptimized()` native function instead of `convertFromRows()`. This should prove faster.
mythrocks
added a commit
to mythrocks/spark-rapids-jni
that referenced
this pull request
May 25, 2023
Fixes NVIDIA#1169. This commit fixes the null counts in row/column conversion, for all output columns. The prior fix in NVIDIA#1155 only fixed the count for STRING outputs. There are 2 additional/tangential fixes in this change: 1. `cudf::detail::null_count()` is used in place of `cudf::null_count()`, thus running on the current stream. 2. The Java `RowConversion.convertFromRowsFixedWidthOptimized()` now uses the `convertFromRowsFixedWidthOptimized()` native function instead of `convertFromRows()`. This should prove faster. Signed-off-by: MithunR <mythrocks@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #1148.
row_conversion.cuwas modified in rapidsai/cudf#13372 to explicitly calculate null-counts for output columns.This commit replicates the changes in rapidsai/cudf/pull/13372, and adds explicit null-count calculation for the string offsets column.