Skip to content

Remove dlopen locator#1676

Merged
elezar merged 1 commit intoNVIDIA:mainfrom
elezar:disable-dlopen-locator
Feb 25, 2026
Merged

Remove dlopen locator#1676
elezar merged 1 commit intoNVIDIA:mainfrom
elezar:disable-dlopen-locator

Conversation

@elezar
Copy link
Member

@elezar elezar commented Feb 25, 2026 •
edited
Loading

This PR removes the addition of a dlopen locator added in #1646.

Addressing this properly is tracked in #1677.

This was removed due to instabilities where cgo errors such as the following are raised:

$ nvidia-ctk cdi generate
munmap_chunk(): invalid pointer
SIGABRT: abort
PC=0xffffb9072008 m=0 sigcode=18446744073709551610
signal arrived during cgo execution

goroutine 1 gp=0x3cb08d5e61e0 m=0 mp=0xf9bd80 [syscall, locked to thread]:
runtime.cgocall(0x820238, 0x3cb08d61de38)
	/usr/local/go/src/runtime/cgocall.go:167 +0x44 fp=0x3cb08d61de00 sp=0x3cb08d61ddc0 pc=0x490204
github.com/NVIDIA/go-nvml/pkg/dl._Cfunc_dlclose(0x3193b0b0)
	_cgo_gotypes.go:119 +0x30 fp=0x3cb08d61de30 sp=0x3cb08d61de00 pc=0x6225f0
github.com/NVIDIA/go-nvml/pkg/dl.(*DynamicLibrary).Close.func1.1(...)
	/go/src/nvidia-container-toolkit/vendor/github.com/NVIDIA/go-nvml/pkg/dl/dl.go:105
github.com/NVIDIA/go-nvml/pkg/dl.(*DynamicLibrary).Close.func1()
	/go/src/nvidia-container-toolkit/vendor/github.com/NVIDIA/go-nvml/pkg/dl/dl.go:105 +0x48 fp=0x3cb08d61de70 sp=0x3cb08d61de30 pc=0x622d78
github.com/NVIDIA/go-nvml/pkg/dl.withOSLock(0x3cb08d61deb8)
	/go/src/nvidia-container-toolkit/vendor/github.com/NVIDIA/go-nvml/pkg/dl/dl.go:72 +0x4c fp=0x3cb08d61dea0 sp=0x3cb08d61de70 pc=0x6229cc
github.com/NVIDIA/go-nvml/pkg/dl.(*DynamicLibrary).Close(0x3cb08da32701?)
	/go/src/nvidia-container-toolkit/vendor/github.com/NVIDIA/go-nvml/pkg/dl/dl.go:104 +0x34 fp=0x3cb08d61ded0 sp=0x3cb08d61dea0 pc=0x622ce4
github.com/NVIDIA/nvidia-container-toolkit/pkg/lookup.dlopenLocator.Locate.func1()
	/go/src/nvidia-container-toolkit/pkg/lookup/dlopen.go:57 +0x20 fp=0x3cb08d61def0 sp=0x3cb08d61ded0 pc=0x626350
github.com/NVIDIA/nvidia-container-toolkit/pkg/lookup.dlopenLocator.Locate({{0x977f00?, 0x3cb08d76f500?}}, {0x94aaa5, 0x11})
	/go/src/nvidia-container-toolkit/pkg/lookup/dlopen.go:74 +0x45c fp=0x3cb08d61e040 sp=0x3cb08d61def0 pc=0x6262cc
github.com/NVIDIA/nvidia-container-toolkit/pkg/lookup.(*dlopenLocator).Locate(0x3cb08d800fb0?, {0x94aaa5?, 0x3cb08da1ed70?})
	<autogenerated>:1 +0x34 fp=0x3cb08d61e070 sp=0x3cb08d61e040 pc=0x629ce4

@elezar elezar force-pushed the disable-dlopen-locator branch from eb860e8 to c1af7f5 Compare February 25, 2026 10:06
@elezar elezar added this to the v1.19.0 milestone Feb 25, 2026
@elezar elezar added the blocker label Feb 25, 2026
@elezar
Remove dlopen locator
8e12188 
The dlopen locator causes invalid pointer errors. We remove it to
as it's not strictly required for the release.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar force-pushed the disable-dlopen-locator branch from c1af7f5 to 8e12188 Compare February 25, 2026 10:53
@elezar elezar mentioned this pull request Feb 25, 2026
Open
@elezar elezar changed the title Disable dlopen locator Removes dlopen locator Feb 25, 2026
@elezar elezar changed the title Removes dlopen locator Remove dlopen locator Feb 25, 2026
@elezar elezar merged commit 3b02c4e into NVIDIA:main Feb 25, 2026
16 checks passed
@elezar elezar deleted the disable-dlopen-locator branch February 25, 2026 12:00
@elezar elezar mentioned this pull request Feb 25, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@klueska klueska klueska approved these changes

@jgehrcke jgehrcke Awaiting requested review from jgehrcke

@cdesiniotis cdesiniotis Awaiting requested review from cdesiniotis

Assignees

No one assigned

Labels

blocker

Projects

None yet

Milestone

v1.19.0

Development

Successfully merging this pull request may close these issues.

2 participants

@elezar @klueska