Merged
Conversation
0a2a189 to
d6f653e
Compare
Pull Request Test Coverage Report for Build 22172411136Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
6f73162 to
369cc05
Compare
cdesiniotis
reviewed
Feb 18, 2026
pkg/lookup/dlopen.go
Outdated
|
|
||
| // NewDlopenLocator creats a locator that can be used for locating libraries | ||
| // through the dlopen mechanism. | ||
| func (f *Factory) NewDlopenLocator() Locator { |
Contributor
There was a problem hiding this comment.
Question -- do we want to make this method private initially? We recently made the constructor for the ldcache locator private in 8e35c22
Member
Author
There was a problem hiding this comment.
Yes, that's a good point. The initial implementation of this predates the refactor (It was one of the motivators for the refactor). I didn't make it private after the rebase.
This change adds a library locator that uses dlopen to try to find a library. Signed-off-by: Evan Lezar <elezar@nvidia.com>
369cc05 to
633ddf3
Compare
cdesiniotis
approved these changes
Feb 19, 2026
This was referenced Feb 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attepts to add a DLOpen locator as required by nix packages: https://github.com/NixOS/nixpkgs/blob/1c415018b24020442ee94e6b84a8a4a24078a61e/pkgs/by-name/nv/nvidia-container-toolkit/0001-Add-dlopen-discoverer.patch#L50
Also requires NVIDIA/go-nvml#171