refactor: Add AsOptional wrapper for lookup.Locator#1645
Merged
elezar merged 4 commits intoNVIDIA:mainfrom Feb 18, 2026
Merged
Conversation
Pull Request Test Coverage Report for Build 22089962467Details
💛 - Coveralls |
cf782be to
00ee9b2
Compare
3090cf9 to
44544c9
Compare
44544c9 to
b00c3eb
Compare
cdesiniotis
approved these changes
Feb 17, 2026
This change moves from a field based check for an optional locator to using a wrapper. This enables simpler composition and makes it simpler to make new locators explicitly optional. Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
b00c3eb to
8e35c22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves from a field based check for an optional locator to using a wrapper. This enables simpler composition and makes it simpler to make new locators explicitly optional.
This includes the changes from #1648 which should be reviewed first.