Merged
Conversation
Pull Request Test Coverage Report for Build 22057622212Details
💛 - Coveralls |
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
b4a48e0 to
72ec6f9
Compare
cdesiniotis
approved these changes
Feb 13, 2026
| candidates, err := chain.Locate(library) | ||
| chain, err := symlinks.ResolveChain(library) | ||
| if err != nil { | ||
| b.logger.Errorf("error processing library %s from ldcache: %v", library, err) |
Contributor
There was a problem hiding this comment.
nit: may be valuable to add a warning message here:
b.logger.Warningf("Failed to resolve symlink chain for library %q: %v", library, err)
Signed-off-by: Evan Lezar <elezar@nvidia.com>
72ec6f9 to
b148b43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change simplifies the lookup of libraries in the Ldcache. Instead of storing a list of cache entries to the libraries they resolve to the cache entries and any symlinks in the chain to the final libraries are stored. This simplifies the lookup of libraries to a list traversal.