fix: Don't inject device nodes when NVIDIA_VISIBLE_DEVICES=none#1562
Merged
elezar merged 3 commits intoNVIDIA:mainfrom Jan 12, 2026
Merged
fix: Don't inject device nodes when NVIDIA_VISIBLE_DEVICES=none#1562elezar merged 3 commits intoNVIDIA:mainfrom
elezar merged 3 commits intoNVIDIA:mainfrom
Conversation
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Member
Author
|
/cherry-pick release-1.18 |
Pull Request Test Coverage Report for Build 20911691037Details
💛 - Coveralls |
1aadeb7 to
af9e7c6
Compare
Signed-off-by: Evan Lezar <elezar@nvidia.com>
af9e7c6 to
84f3314
Compare
cdesiniotis
approved these changes
Jan 9, 2026
This change adds support for generating a CDI spec for a nvidia.com/gpu=none device. Signed-off-by: Evan Lezar <elezar@nvidia.com>
84f3314 to
cab62ee
Compare
|
🤖 Backport PR created for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in the
jit-cdimode whereNVIDIA_VISIBLE_DEVICES=nonebehaves the same way asNVIDIA_VISIBLE_DEVICES=all. These changes add a (initially failing) integration test for this case as well as fixing the behaviour.Support is also added for generating a CDI spec for an
nvidia.com/gpu=nonedevice when running:Fixes #1555
See failing test case added here https://github.com/NVIDIA/nvidia-container-toolkit/actions/runs/20808503321/job/59767855888?pr=1562