[kernel] block on cloud-init before beginning any setup#552
Merged
ArangoGutierrez merged 1 commit intomainfrom Dec 13, 2025
Merged
[kernel] block on cloud-init before beginning any setup#552ArangoGutierrez merged 1 commit intomainfrom
ArangoGutierrez merged 1 commit intomainfrom
Conversation
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
Pull Request Test Coverage Report for Build 20185497932Details
💛 - Coveralls |
Contributor
Author
|
This change is inspired by this comment hashicorp/packer#2639 (comment) |
dims
approved these changes
Dec 13, 2025
ArangoGutierrez
approved these changes
Dec 13, 2025
ArangoGutierrez
added a commit
to ArangoGutierrez/holodeck
that referenced
this pull request
Jan 8, 2026
- Add cloud-init status --wait to common functions so ALL templates wait for cloud-init to complete before provisioning - Remove duplicate cloud-init wait from kernel.go (now in common) - Increase container runtime startup timeouts to 120s for slow VMs - Log progress every 15s instead of 10s during wait loops This addresses race conditions where provisioning starts before cloud-init finishes setting up apt sources and systemd services. Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change should fix the
apt install linux-image-${KERNEL_VERSION}failures observed in our driver container's e2e pipelines:My theory is that holodeck is attempting to perform instance setup a bit too early as I did see some differences in the output of
apt-get updatecommand when called from holodeck at different times. Below are theapt-get updateoutputs gathered from passing pipelines both of which are called from the holodeck run but at different times:apt-get updateoutput 1apt-get output2Comparing the above two outputs, one can see that the
http://us-west-1.ec2.archive.ubuntu.comshows up as an apt source later. This leads to me believe that we may be running ouraptcalls too prematurely before cloud-init gets a chance to complete its setup.