Prepare release 0.2.14 by ArangoGutierrez · Pull Request #434 · NVIDIA/holodeck

ArangoGutierrez · 2025-07-30T14:37:47Z

No description provided.

Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.29.17 to 1.29.18. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@config/v1.29.17...config/v1.29.18) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/config dependency-version: 1.29.18 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

The Execute method had redundant template execution logic that was already handled earlier in the function. This change removes the duplicate code block to clean up the implementation. Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

….com/aws/aws-sdk-go-v2/config-1.29.18 Bump github.com/aws/aws-sdk-go-v2/config from 1.29.17 to 1.29.18

Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.37.0 to 1.38.0. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.37.0...v1.38.0) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-version: 1.38.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

….com/onsi/gomega-1.38.0 Bump github.com/onsi/gomega from 1.37.0 to 1.38.0

Bumps [github.com/aws/aws-sdk-go-v2/service/ssm](https://github.com/aws/aws-sdk-go-v2) from 1.60.0 to 1.60.2. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@service/s3/v1.60.0...service/ssm/v1.60.2) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/ssm dependency-version: 1.60.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

….com/aws/aws-sdk-go-v2/service/ssm-1.60.2 Bump github.com/aws/aws-sdk-go-v2/service/ssm from 1.60.0 to 1.60.2

Bumps [github.com/aws/aws-sdk-go-v2/service/ec2](https://github.com/aws/aws-sdk-go-v2) from 1.232.0 to 1.234.0. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@service/ec2/v1.232.0...service/ec2/v1.234.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/ec2 dependency-version: 1.234.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

….com/aws/aws-sdk-go-v2/service/ec2-1.234.0 Bump github.com/aws/aws-sdk-go-v2/service/ec2 from 1.232.0 to 1.234.0

Remove duplicate template execution code in container-toolkit.go

- Add utils.GetIPAddress() with HTTP-based IP detection services - Implement fallback services (ipify.org, ifconfig.me, icanhazip.com, ident.me) - Add timeout protection (15s overall, 5s per service) and context support - Include IP validation and proper CIDR notation (/32) for AWS API - Use utils.GetIPAddress() in AWS security group creation - Fix "CIDR block malformed" error in security group creation The new utils package provides reliable public IP detection with proper CIDR formatting, ensuring AWS security groups are created with valid IP ranges for external access. Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

Create IP detection utils and use in AWS security group creation

Bumps [github.com/aws/aws-sdk-go-v2/service/ec2](https://github.com/aws/aws-sdk-go-v2) from 1.234.0 to 1.235.0. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@service/ec2/v1.234.0...service/ec2/v1.235.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/ec2 dependency-version: 1.235.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

….com/aws/aws-sdk-go-v2/service/ec2-1.235.0 Bump github.com/aws/aws-sdk-go-v2/service/ec2 from 1.234.0 to 1.235.0

Bumps [sigs.k8s.io/yaml](https://github.com/kubernetes-sigs/yaml) from 1.5.0 to 1.6.0. - [Release notes](https://github.com/kubernetes-sigs/yaml/releases) - [Changelog](https://github.com/kubernetes-sigs/yaml/blob/master/RELEASE.md) - [Commits](kubernetes-sigs/yaml@v1.5.0...v1.6.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/yaml dependency-version: 1.6.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…8s.io/yaml-1.6.0 Bump sigs.k8s.io/yaml from 1.5.0 to 1.6.0

Bumps [github.com/aws/aws-sdk-go-v2/service/ec2](https://github.com/aws/aws-sdk-go-v2) from 1.235.0 to 1.236.0. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@service/ec2/v1.235.0...service/ec2/v1.236.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/ec2 dependency-version: 1.236.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

….com/aws/aws-sdk-go-v2/service/ec2-1.236.0 Bump github.com/aws/aws-sdk-go-v2/service/ec2 from 1.235.0 to 1.236.0

Bumps [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2) from 1.36.6 to 1.37.0. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@v1.36.6...v1.37.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2 dependency-version: 1.37.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

….com/aws/aws-sdk-go-v2-1.37.0 Bump github.com/aws/aws-sdk-go-v2 from 1.36.6 to 1.37.0

Bumps [github.com/aws/aws-sdk-go-v2/service/ec2](https://github.com/aws/aws-sdk-go-v2) from 1.236.0 to 1.237.0. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@service/ec2/v1.236.0...service/ec2/v1.237.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/ec2 dependency-version: 1.237.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

….com/aws/aws-sdk-go-v2/service/ec2-1.237.0 Bump github.com/aws/aws-sdk-go-v2/service/ec2 from 1.236.0 to 1.237.0

Bumps [github.com/aws/aws-sdk-go-v2/service/ssm](https://github.com/aws/aws-sdk-go-v2) from 1.60.2 to 1.61.0. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@service/ssm/v1.60.2...service/s3/v1.61.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/ssm dependency-version: 1.61.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

….com/aws/aws-sdk-go-v2/service/ssm-1.61.0 Bump github.com/aws/aws-sdk-go-v2/service/ssm from 1.60.2 to 1.61.0

Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.29.18 to 1.30.1. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@config/v1.29.18...v1.30.1) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/config dependency-version: 1.30.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

….com/aws/aws-sdk-go-v2/config-1.30.1 Bump github.com/aws/aws-sdk-go-v2/config from 1.29.18 to 1.30.1

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

Fix containerd and CNI install

copy-pr-bot · 2025-07-30T14:37:50Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

ArangoGutierrez · 2025-07-30T14:38:05Z

/ok to test

copy-pr-bot · 2025-07-30T14:38:08Z

/ok to test

@ArangoGutierrez, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

Copilot

Pull Request Overview

This PR prepares for release 0.2.14 with automatic IP detection functionality for AWS environments, eliminates the need for manual IP configuration in security groups, and includes various improvements to containerd configuration and test coverage.

Introduces automatic public IP detection to simplify AWS security group configuration
Updates containerd default version and unifies configuration for better compatibility
Adds interactive provisioning failure handling with cleanup options

Reviewed Changes

Copilot reviewed 28 out of 936 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pkg/utils/ip.go	New IP detection utility with fallback services and validation
pkg/provider/aws/create.go	Integrates automatic IP detection into security group creation
api/holodeck/v1alpha1/types.go	Fixes typo in field name from IngresIpRanges to IngressIpRanges
pkg/provisioner/templates/containerd.go	Updates default version to 1.7.28 and unifies configuration
cmd/cli/create/create.go	Adds interactive provisioning failure handling
tests/data/*.yml	Removes hardcoded IP ranges from test configurations
docs/	Updates documentation to reflect automatic IP detection
examples/	Updates example configurations with optional IP ranges

Comments suppressed due to low confidence (1)

tests/aws_test.go:105

The test removes validation for IngresIpRanges but doesn't add validation for the new automatic IP detection functionality. Consider adding a test to verify that IP ranges are properly populated after automatic detection.

		Expect(state.opts.cfg.Spec.Instance.Region).NotTo(BeEmpty(), "Region should not be empty")

Copilot · 2025-07-30T14:38:27Z

pkg/provisioner/templates/container-toolkit.go

-		return fmt.Errorf("failed to execute container-toolkit template: %v", err)
-	}
-
 	return nil


The template execution code was removed but the template variable containerTlktTemplate is still defined and used. This will cause the template to not be executed, resulting in incomplete container toolkit setup.

Copilot · 2025-07-30T14:38:27Z

pkg/utils/ip.go

+	if err != nil {
+		return "", fmt.Errorf("error fetching IP from %s: %v", url, err)
+	}
+	defer resp.Body.Close() // nolint:errcheck, gosec, staticcheck


Using nolint directives to suppress error checking on resp.Body.Close() is not recommended. Consider checking the error or using a blank identifier assignment if the error is intentionally ignored.

Suggested change

defer resp.Body.Close() // nolint:errcheck, gosec, staticcheck

defer func() {

if err := resp.Body.Close(); err != nil {

fmt.Printf("warning: error closing response body: %v\n", err)

}

}()

ArangoGutierrez · 2025-07-30T14:38:39Z

/ok to test 14a7880

dependabot bot and others added 30 commits July 21, 2025 00:23

Merge pull request #416 from NVIDIA/dependabot/go_modules/main/github…

ff4549c

….com/aws/aws-sdk-go-v2/config-1.29.18 Bump github.com/aws/aws-sdk-go-v2/config from 1.29.17 to 1.29.18

Merge pull request #421 from NVIDIA/dependabot/go_modules/main/github…

fce1c18

….com/onsi/gomega-1.38.0 Bump github.com/onsi/gomega from 1.37.0 to 1.38.0

Merge pull request #418 from NVIDIA/dependabot/go_modules/main/github…

0ff714d

….com/aws/aws-sdk-go-v2/service/ssm-1.60.2 Bump github.com/aws/aws-sdk-go-v2/service/ssm from 1.60.0 to 1.60.2

Merge pull request #420 from NVIDIA/dependabot/go_modules/main/github…

3fa9929

….com/aws/aws-sdk-go-v2/service/ec2-1.234.0 Bump github.com/aws/aws-sdk-go-v2/service/ec2 from 1.232.0 to 1.234.0

Merge pull request #422 from ArangoGutierrez/devel/toolkit

8c6a120

Remove duplicate template execution code in container-toolkit.go

[no-relnote] Update test data files

fd8289b

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

[no-relnote] Update documentation for IP detection

b0713d2

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

[no-relnote] Fix lints

caa94f0

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

[no-relnote] Remove check on aws_test for empty IP range

b63c2e2

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

[no-relnote] Fix typo on instance.IngressIpRanges

2f324b6

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

[no-relnote] Name user agent just Holodeck

eb5da43

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

Merge pull request #423 from ArangoGutierrez/get_ip

8b26d05

Create IP detection utils and use in AWS security group creation

Merge pull request #424 from NVIDIA/dependabot/go_modules/main/github…

e612816

….com/aws/aws-sdk-go-v2/service/ec2-1.235.0 Bump github.com/aws/aws-sdk-go-v2/service/ec2 from 1.234.0 to 1.235.0

Merge pull request #425 from NVIDIA/dependabot/go_modules/main/sigs.k…

2851f0a

…8s.io/yaml-1.6.0 Bump sigs.k8s.io/yaml from 1.5.0 to 1.6.0

Merge pull request #426 from NVIDIA/dependabot/go_modules/main/github…

c53edc8

….com/aws/aws-sdk-go-v2/service/ec2-1.236.0 Bump github.com/aws/aws-sdk-go-v2/service/ec2 from 1.235.0 to 1.236.0

Merge pull request #427 from NVIDIA/dependabot/go_modules/main/github…

57fb07c

….com/aws/aws-sdk-go-v2-1.37.0 Bump github.com/aws/aws-sdk-go-v2 from 1.36.6 to 1.37.0

Merge pull request #429 from NVIDIA/dependabot/go_modules/main/github…

765b8f2

….com/aws/aws-sdk-go-v2/service/ec2-1.237.0 Bump github.com/aws/aws-sdk-go-v2/service/ec2 from 1.236.0 to 1.237.0

Merge pull request #430 from NVIDIA/dependabot/go_modules/main/github…

aa96e57

….com/aws/aws-sdk-go-v2/service/ssm-1.61.0 Bump github.com/aws/aws-sdk-go-v2/service/ssm from 1.60.2 to 1.61.0

dependabot bot and others added 6 commits July 30, 2025 12:39

Merge pull request #431 from NVIDIA/dependabot/go_modules/main/github…

bb880fd

….com/aws/aws-sdk-go-v2/config-1.30.1 Bump github.com/aws/aws-sdk-go-v2/config from 1.29.18 to 1.30.1

[no-relnote] Fix containerd and CNI install

58809a6

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

[no-relnote] enhance create UX

52985dc

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

[no-relnote] update unit tests

35da471

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

Merge pull request #432 from ArangoGutierrez/get_ip

14a7880

Fix containerd and CNI install

ArangoGutierrez requested review from cdesiniotis, elezar and tariq1890 as code owners July 30, 2025 14:37

ArangoGutierrez self-assigned this Jul 30, 2025

ArangoGutierrez requested review from Copilot and removed request for cdesiniotis, elezar and tariq1890 July 30, 2025 14:37

Copilot AI reviewed Jul 30, 2025

View reviewed changes

ArangoGutierrez merged commit ae9feb4 into release-0.2 Jul 30, 2025
31 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare release 0.2.14#434

Prepare release 0.2.14#434
ArangoGutierrez merged 36 commits intorelease-0.2from
main

ArangoGutierrez commented Jul 30, 2025

Uh oh!

copy-pr-bot bot commented Jul 30, 2025

Uh oh!

ArangoGutierrez commented Jul 30, 2025

Uh oh!

copy-pr-bot bot commented Jul 30, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 30, 2025

Uh oh!

Copilot AI Jul 30, 2025

Uh oh!

ArangoGutierrez commented Jul 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-	defer resp.Body.Close() // nolint:errcheck, gosec, staticcheck
+	defer func() {
+		if err := resp.Body.Close(); err != nil {
+			fmt.Printf("warning: error closing response body: %v\n", err)
+		}
+	}()

Conversation

ArangoGutierrez commented Jul 30, 2025

Uh oh!

copy-pr-bot bot commented Jul 30, 2025

Uh oh!

ArangoGutierrez commented Jul 30, 2025

Uh oh!

copy-pr-bot bot commented Jul 30, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

ArangoGutierrez commented Jul 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants