Remove duplicate template execution code in container-toolkit.go#422
Merged
ArangoGutierrez merged 1 commit intoNVIDIA:mainfrom Jul 23, 2025
Merged
Remove duplicate template execution code in container-toolkit.go#422ArangoGutierrez merged 1 commit intoNVIDIA:mainfrom
ArangoGutierrez merged 1 commit intoNVIDIA:mainfrom
Conversation
The Execute method had redundant template execution logic that was already handled earlier in the function. This change removes the duplicate code block to clean up the implementation. Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
There was a problem hiding this comment.
Pull Request Overview
This PR removes duplicate template execution logic in the ContainerToolkit.Execute method. The same template execution code was being called twice with identical parameters and error handling.
- Removes redundant
containerTlktTemplate.Execute()call that was duplicating existing functionality - Cleans up the Execute method implementation by eliminating unnecessary code
Pull Request Test Coverage Report for Build 16465948686Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Execute method had redundant template execution logic that was already handled earlier in the function. This change removes the duplicate code block to clean up the implementation.