Skip to content

Expands regexp to also match 64k page size kernels#1210

Merged
tariq1890 merged 1 commit into
NVIDIA:mainfrom
mvazquezc:fix-1207
Jan 28, 2025
Merged

Expands regexp to also match 64k page size kernels#1210
tariq1890 merged 1 commit into
NVIDIA:mainfrom
mvazquezc:fix-1207

Conversation

@mvazquezc

Copy link
Copy Markdown
Contributor

@copy-pr-bot

copy-pr-bot Bot commented Jan 17, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@tariq1890

Copy link
Copy Markdown
Contributor

Thanks a lot or this @mvazquezc ! Two things

  1. Can we write up quick unit tests with the scenarios you've mentioned in the playground link?
  2. Your fix would need to be applied here as well

Signed-off-by: Mario Vazquez <mavazque@redhat.com>
@mvazquezc

Copy link
Copy Markdown
Contributor Author

hey @tariq1890, I just force-pushed the requested changes. Let me know if there is anything else that needs changes.

@tariq1890

Copy link
Copy Markdown
Contributor

/ok-to-test

1 similar comment
@tariq1890

Copy link
Copy Markdown
Contributor

/ok-to-test

@tariq1890 tariq1890 merged commit 93507e7 into NVIDIA:main Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Operator fails to render a valid daemonset on OCP when using 64K kernel page size.

3 participants