feat: add B200 accelerator type support#437
Conversation
Add NVIDIA B200 (standalone Blackwell GPU) as a recognized accelerator type in the criteria system and snapshot auto-detection. Closes #436
Coverage Report ✅
Coverage BadgeMerging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
yuanchen8911
left a comment
There was a problem hiding this comment.
LGTM. Clean, well-scoped change with good test coverage.
One note: the matchAccelerator ordering is correct — gb200 is checked before b200, so a "GB200" model string won't false-match as B200. Worth a comment in the code to make this ordering dependency explicit for future maintainers (e.g., if someone adds "GB300" they need to check it before a hypothetical "B300").
Nit (non-blocking): consider adding a comment above the b200 case in matchAccelerator:
// b200 must be checked after gb200 to avoid false-matching GB200 models.
yuanchen8911
left a comment
There was a problem hiding this comment.
One more thing — the doc/comments should be updated to include b200:
pkg/recipe/criteria.go:210—Acceleratorfield comment still lists onlyh100, gb200, a100, l40pkg/recipe/doc.go:68anddoc.go:118— package docs and API query parameter lists omitb200
Not a blocker but users/API consumers will miss it otherwise.
- Add ordering comment in matchAccelerator explaining gb200 must be checked before b200 to prevent false-matching GB200 model strings - Update Criteria.Accelerator field comment to include b200 - Update doc.go type synopsis, accelerator list, and HTTP query parameter docs to include b200
Updated, ready to re-review |
Add NVIDIA B200 (standalone Blackwell GPU) as a recognized accelerator type in the criteria system and snapshot auto-detection. Changes: - Add `CriteriaAcceleratorB200` constant and parsing logic - Add snapshot auto-detection for "B200" model strings (ordered after GB200 to prevent false matches) - Update package documentation and API query parameter lists to include b200 - Add unit tests for parsing and snapshot extraction Closes NVIDIA#436
Summary
b200as a recognizedCriteriaAcceleratorTypefor standalone NVIDIA Blackwell B200 GPUsmatchAccelerator()for GPU model strings containing "B200"Closes #436
Test plan
TestParseCriteriaAcceleratorType— verifies"b200"parses toCriteriaAcceleratorB200TestMatchAccelerator— verifies"NVIDIA-B200"model string matches B200TestExtractCriteriaFromSnapshot— verifies B200 extraction from snapshot measurementsmake testpasses (pre-existing togetherai overlay failures unrelated)make lint—go vetpasses (golangci-lint has pre-existing toolchain mismatch)