fix(gke): remove CAP_ prefix from capability names in TCPXO manifests#428
Merged
yuanchen8911 merged 1 commit intoNVIDIA:mainfrom Mar 19, 2026
Merged
Conversation
mchmarny
approved these changes
Mar 18, 2026
Kubernetes capability entries should omit the CAP_ prefix per the API spec. Use NET_ADMIN and NET_BIND_SERVICE instead of CAP_NET_ADMIN and CAP_NET_BIND_SERVICE. Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
280e3d7 to
3c05ac3
Compare
xdu31
pushed a commit
to xdu31/aicr
that referenced
this pull request
Mar 24, 2026
…NVIDIA#428) Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
CAP_prefix from Kubernetes capability names in TCPXO demo manifest and documentation. The Kubernetes API spec expects capability names without the prefix (e.g.,NET_ADMINnotCAP_NET_ADMIN).Files changed:
demos/workloads/training/gke-nccl-test-tcpxo.yamldocs/integrator/gke-tcpxo-networking.mdReference: https://kubernetes.io/docs/tasks/configure-pod-container/security-context/#set-capabilities-for-a-container
Test plan