fix: ArgoCD deployer generates valid YAML, add structural validation (#410)#413
Merged
fix: ArgoCD deployer generates valid YAML, add structural validation (#410)#413
Conversation
mchmarny
approved these changes
Mar 16, 2026
Coverage Report ✅
Coverage BadgeNo Go source files changed in this PR. |
xdu31
pushed a commit
to xdu31/aicr
that referenced
this pull request
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
application.yaml.tmplthat causedsources:anddestination:to render at column 0 instead of underspec:, producing invalid YAMLTestGenerate_ApplicationYAMLStructureunit test that parses generated ArgoCD Application YAML and validates the document structure (spec.sources, spec.destination, spec.source.path)assertValidYAMLchecks to existing ArgoCD deployer testsargocd-deployerstepbundle/from yamllint (generated output, already gitignored)Close #410
Test plan
make testpassesmake lint-gopasses (0 issues)make e2epasses (17/17 including yamllint on ArgoCD bundle output)make qualifypassesType of Change
Component(s) Affected
cmd/aicr,pkg/cli)cmd/aicrd,pkg/api,pkg/server)pkg/recipe)pkg/bundler,pkg/component/*)pkg/collector,pkg/snapshotter)pkg/validator)pkg/errors,pkg/k8s)docs/,examples/)Implementation Notes
Testing
# Commands run (prefer `make qualify` for non-trivial changes) make qualifyRisk Assessment
Rollout notes:
Checklist
make testwith-race)make lint)git commit -S) — GPG signing info