ci: build and publish validator images on merge to main#412
Merged
mchmarny merged 1 commit intoNVIDIA:mainfrom Mar 17, 2026
Merged
ci: build and publish validator images on merge to main#412mchmarny merged 1 commit intoNVIDIA:mainfrom
mchmarny merged 1 commit intoNVIDIA:mainfrom
Conversation
mchmarny
reviewed
Mar 16, 2026
Member
mchmarny
left a comment
There was a problem hiding this comment.
Clean CI change — job structure mirrors on-tag nicely, action pins are solid, and the edge/sha tagging strategy is well thought out. One inline comment on the concurrency side effect. LGTM otherwise.
Contributor
|
Reusable workflow opportunity. build-docker and docker-manifest are almost identical to on-tag — only the tag pattern and if guard differ. Worth extracting to a reusable workflow with inputs for tag strategy. Not a blocker, but reduces drift risk as these evolve. |
d53ead8 to
025ae65
Compare
Add build-docker and docker-manifest jobs to the on-push workflow, gated on push to main (skipped for PRs). This keeps validator images testable from main without requiring a release tag. Tags produced per merge: - sha-<commit>: immutable multi-arch tag for rollback and provenance - edge: mutable tag tracking latest main (not release-grade) :latest is reserved for the on-tag release pipeline where vuln scan and attestation are enforced. Concurrency is split so PRs are cancelled on new pushes but main merges always run to completion for immutable tag guarantees. Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
025ae65 to
ae635f4
Compare
Contributor
Author
|
Summary of offline discussion:
|
mchmarny
approved these changes
Mar 17, 2026
xdu31
pushed a commit
to xdu31/aicr
that referenced
this pull request
Mar 24, 2026
Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add validator image builds to the on-push workflow so images stay testable from main without requiring a release tag.
Motivation / Context
Validator images are currently only published on tagged releases. This creates a gap between merging code and being able to test updated validators on a live cluster — e.g., #403 (GKE NCCL support) is merged but the performance validator image doesn't include it until a new release is cut.
Fixes: N/A
Related: #403, #387
Type of Change
Component(s) Affected
.github/workflows/on-push.yamlImplementation Notes
build-dockerjob: builds 3 validator images × 2 archs (6 parallel jobs), gated onpushto main only (skipped for PRs)docker-manifestjob: creates multi-arch manifests with two tag types:sha-<commit>— immutable per-commit tag for rollback and provenanceedge— mutable tag tracking latest main (not release-grade):latestis untouched — reserved for the on-tag release pipeline where vuln scan + attestation are enforcedTesting
Risk Assessment
Rollout notes: N/A — additive workflow change, no impact on existing on-tag release pipeline.
Checklist
make testwith-race)make lint)git commit -S)