fix: deploy.sh retry logic, CUJ2 doc cleanup, and test reporting guide#404
Merged
fix: deploy.sh retry logic, CUJ2 doc cleanup, and test reporting guide#404
Conversation
mchmarny
approved these changes
Mar 13, 2026
mchmarny
requested changes
Mar 13, 2026
Member
mchmarny
left a comment
There was a problem hiding this comment.
Good PR — retry logic, signal handling, CUJ2 doc cleanup, and cert-manager migration are all solid improvements. The cosign version detection simplification is a nice cleanup too.
Two issues need fixing before merge:
Must fix:
- retry() off-by-one —
MAX_RETRIES=5only gives 4 retries (5 total runs), not 5 retries (6 total) as documented. The error message also overcounts by 1. Fix:-ge→-gtand$((attempt + 1))→${attempt}. - apply_ignoring_crd_race lost fail-safe — The old inline code explicitly failed on unrecognized error formats (
elif [[ -z "${err_lines}" ]]). The new function silently returns success when errors match neither CRD-race nor real-error patterns. This is a safety regression for unexpected kubectl failure modes.
Nice to have:
3. Validate --retries is numeric (avoid arithmetic errors on bad input)
4. Test assertion for cert-manager values checks "enabled" which is too generic
Coverage Report ✅
Coverage BadgeNo Go source files changed in this PR. |
- Add retry logic to the deploy.sh - Cleaned a regex's in deploy.sh - Add INT/TERM signal trap to deploy.sh template so Ctrl+C exits cleanly - Document --retries 0 (fail-fast) in deploy.sh usage comment - Remove non-existent hf-token-secret.yaml step from CUJ2 doc - Add demos/README.md with demo index and session recording guide - Add example CUJ2 test report in demos/examples/
f1ffe2f to
989de3f
Compare
mchmarny
approved these changes
Mar 13, 2026
xdu31
pushed a commit
to xdu31/aicr
that referenced
this pull request
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #335
Motivation / Context
Fixes:
Related:
Type of Change
Component(s) Affected
cmd/aicr,pkg/cli)cmd/aicrd,pkg/api,pkg/server)pkg/recipe)pkg/bundler,pkg/component/*)pkg/collector,pkg/snapshotter)pkg/validator)pkg/errors,pkg/k8s)docs/,examples/)Implementation Notes
Testing
# Commands run (prefer `make qualify` for non-trivial changes) make qualifyRisk Assessment
Rollout notes:
Checklist
make testwith-race)make lint)git commit -S) — GPG signing info