fix(evidence): track check results at runtime instead of scanning directory#396
Merged
mchmarny merged 2 commits intoNVIDIA:mainfrom Mar 13, 2026
Merged
Conversation
…ectory The evidence summary previously scanned the output directory for .md files, which could report stale results from previous runs. Now each check's result is recorded at runtime via run_check() wrapper, and the summary only shows checks that actually executed. Fixes: NVIDIA#392 Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
mchmarny
approved these changes
Mar 13, 2026
xdu31
pushed a commit
to xdu31/aicr
that referenced
this pull request
Mar 24, 2026
…ectory (NVIDIA#396) Signed-off-by: Yuan Chen <yuanchen97@gmail.com> Co-authored-by: Mark Chmarny <mchmarny@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace directory-scanning summary in
collect-evidence.shwith runtime result tracking. A newrun_check()wrapper records each check's outcome as it executes, so the final summary only reflects checks from the current run — not stale files from previous runs.Motivation / Context
The evidence summary scanned
EVIDENCE_DIRfor.mdfiles, which meant leftover files from earlier runs could inflate pass counts or hide regressions.Fixes: #392
Related: N/A
Type of Change
Component(s) Affected
cmd/aicr,pkg/cli)cmd/aicrd,pkg/api,pkg/server)pkg/recipe)pkg/bundler,pkg/component/*)pkg/collector,pkg/snapshotter)pkg/validator)pkg/errors,pkg/k8s)docs/,examples/)pkg/evidence/scripts/collect-evidence.shImplementation Notes
CHECK_RESULTSglobal variable andrun_check()helper afterwait_for_port().casestatement (individual andall) now goes throughrun_check.CHECK_RESULTSinstead of globbing the evidence directory.Testing
# Script is a bash helper — verified via shellcheck and manual review shellcheck pkg/evidence/scripts/collect-evidence.shRisk Assessment
Rollout notes: N/A
Checklist
make testwith-race)make lint)git commit -S) — GPG signing info