fix(bundler): clean up kai-resource-reservation namespace on undeploy#394
Merged
mchmarny merged 1 commit intoNVIDIA:mainfrom Mar 13, 2026
Merged
Conversation
The kai-scheduler creates a kai-resource-reservation namespace at runtime for resource reservations. This namespace is not in the bundle's namespace list and was left behind after undeploy. Fixes: NVIDIA#390 Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
mchmarny
approved these changes
Mar 13, 2026
xdu31
pushed a commit
to xdu31/aicr
that referenced
this pull request
Mar 24, 2026
…NVIDIA#394) Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kai-resource-reservationnamespace during undeploy, which is created at runtime by the kai-scheduler but is not tracked in the bundle's namespace list.Motivation / Context
The kai-scheduler creates a
kai-resource-reservationnamespace at runtime for resource reservations. Since this namespace is not part of the bundle's declared namespace list,undeploy.shnever deleted it, leaving it behind on the cluster.Fixes: #390
Related: N/A
Type of Change
Component(s) Affected
cmd/aicr,pkg/cli)cmd/aicrd,pkg/api,pkg/server)pkg/recipe)pkg/bundler,pkg/component/*)pkg/collector,pkg/snapshotter)pkg/validator)pkg/errors,pkg/k8s)docs/,examples/)Implementation Notes
The
delete_namespacehelper already handles--keep-namespaces, protected namespace checks, and missing namespaces gracefully — so this is a safe, no-op addition when the namespace does not exist.Testing
Build passes. The template change is a shell script addition that uses the existing
delete_namespacefunction.Risk Assessment
Rollout notes: N/A — takes effect on next bundle generation.
Checklist
make testwith-race)make lint)git commit -S) — GPG signing info