fix(validator): remove helm-values check (Helm values stored in secrets, never available in snapshot)#388
Merged
xdu31 merged 1 commit intoNVIDIA:mainfrom Mar 13, 2026
Conversation
…ts, never available in snapshot)
mchmarny
approved these changes
Mar 13, 2026
Member
mchmarny
left a comment
There was a problem hiding this comment.
1 nit, not a blocker:
doc reference in docs/contributor/validator.md:11 (deployment phase example still mentions "Helm values match recipe")
| `deployment` | Verify components are installed and healthy | GPU operator pods running, Helm values match recipe |
25 tasks
1 task
xdu31
added a commit
to xdu31/aicr
that referenced
this pull request
Mar 24, 2026
…ts, never available in snapshot) (NVIDIA#388)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
helm-valuesdeployment check — Helm/Argo release values are stored in Kubernetes secrets, so the snapshot never captures them and this check always skippedhelm_values.go) and tests (helm_values_test.go)Changes
validators/deployment/helm_values.govalidators/deployment/helm_values_test.govalidators/deployment/main.gohelm-valuesregistration and usage commentrecipes/validators/catalog.yamlrecipes/validators/README.mdrecipes/overlays/h100-eks-ubuntu-training.yamlrecipes/overlays/h100-eks-ubuntu-inference-dynamo.yamlTest plan
go build ./validators/deployment/compiles cleanlygo test ./validators/... ./pkg/validator/...all pass