feat(gke): update skyhook to not be runtimeRequired#380
Merged
yuanchen8911 merged 1 commit intofeat/gke-cos-training-overlaysfrom Mar 12, 2026
Merged
Conversation
837dda2 to
d059741
Compare
47bd023 to
d3fcc18
Compare
lockwobr
approved these changes
Mar 12, 2026
yuanchen8911
approved these changes
Mar 12, 2026
Contributor
yuanchen8911
left a comment
There was a problem hiding this comment.
PR removes runtimeRequired from GKE tuning Skyhook spec (tuning-gke.yaml#L38 (https://github.com/NVIDIA/aicr/blob/feat/gke-
cos-training-overlays-skyhookUpdate/recipes/components/skyhook-customizations/manifests/tuning-gke.yaml#L38)), so runtime-
required gating is no longer enabled for this path.
- But docs still describe --workload-gate as ensuring runtime-required scheduling gate in general (cli-reference.md#L841
(https://github.com/NVIDIA/aicr/blob/feat/gke-cos-training-overlays-skyhookUpdate/docs/user/cli-reference.md#L841)). - Recommendation: add a GKE/COS caveat in docs (or overlay docs) that this path intentionally does not use runtimeRequired.
- Also change to 0.1.1 for nvidia-tuning-gke to better support gb200 - Add documentation about the differences between gke and other services
d3fcc18 to
a2e37ab
Compare
yuanchen8911
pushed a commit
that referenced
this pull request
Mar 12, 2026
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also change to 0.1.1 for nvidia-tuning-gke to better support gb200
Summary
Motivation / Context
Fixes:
Related:
Type of Change
Component(s) Affected
cmd/aicr,pkg/cli)cmd/aicrd,pkg/api,pkg/server)pkg/recipe)pkg/bundler,pkg/component/*)pkg/collector,pkg/snapshotter)pkg/validator)pkg/errors,pkg/k8s)docs/,examples/)Implementation Notes
Testing
# Commands run (prefer `make qualify` for non-trivial changes) make qualifyRisk Assessment
Rollout notes:
Checklist
make testwith-race)make lint)git commit -S) — GPG signing info