fix: brew formula follows Homebrew best practices#377
Merged
Conversation
- Remove cosign verification from install block (no network during install) - Move verification instructions to caveats as a post-install step - Add test block with version assertion - Expand caveats with full cosign verify-blob-attestation command
lalitadithya
approved these changes
Mar 12, 2026
Coverage Report ✅
Coverage BadgeNo Go source files changed in this PR. |
xdu31
pushed a commit
to xdu31/aicr
that referenced
this pull request
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cosign verify-blob-attestationfrom theinstallblock — Homebrew discourages network access during install, and thewhich("cosign")check is not a declared dependency, so verification was silently skipped for most userscaveatsas a documented post-install step with correct#{opt_bin}pathstestblock (aicr version) sobrew test aicrworkscaveatsto explain both provenance verification and trust root updateNote: GoReleaser reports
brewsis being deprecated in favor ofhomebrew_casks— that's a separate migration.Test plan
goreleaser checkvalidates configmake lintpassesmake testpasses