Skip to content

fix(install): replace post_install with caveats to avoid Homebrew sandbox error#345

Merged
lockwobr merged 1 commit intomainfrom
fix/remove-post-install-sandbox-permissions
Mar 11, 2026
Merged

fix(install): replace post_install with caveats to avoid Homebrew sandbox error#345
lockwobr merged 1 commit intomainfrom
fix/remove-post-install-sandbox-permissions

Conversation

@lockwobr
Copy link
Copy Markdown
Contributor

Summary

  • Homebrew sandbox blocks writes to ~/.sigstore/ during post_install, causing aicr trust update to fail on install
  • Replaced post_install with caveats so users are prompted to run the command after installation instead

Test plan

  • brew install aicr completes without sandbox permission errors
  • Caveat message displays after install with aicr trust update command
  • aicr trust update works when run manually post-install

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • Build/CI/tooling

Component(s) Affected

  • CLI (cmd/aicr, pkg/cli)
  • API server (cmd/aicrd, pkg/api, pkg/server)
  • Recipe engine / data (pkg/recipe)
  • Bundlers (pkg/bundler, pkg/component/*)
  • Collectors / snapshotter (pkg/collector, pkg/snapshotter)
  • Validator (pkg/validator)
  • Core libraries (pkg/errors, pkg/k8s)
  • Docs/examples (docs/, examples/)
  • Other: ____________

Implementation Notes

Risk Assessment

  • Low — Isolated change, well-tested, easy to revert
  • Medium — Touches multiple components or has broader impact
  • High — Breaking change, affects critical paths, or complex rollout

Rollout notes:

Checklist

  • Tests pass locally (make test with -race)
  • Linter passes (make lint)
  • I did not skip/disable tests to make CI green
  • I added/updated tests for new functionality
  • I updated docs if user-facing behavior changed
  • Changes follow existing patterns in the codebase
  • Commits are cryptographically signed (git commit -S) — GPG signing info

…dbox error

Homebrew's sandbox blocks filesystem writes to ~/.sigstore/ during
post_install, causing trust update to fail. Use caveats instead to
prompt users to run the command after installation.
@lockwobr lockwobr self-assigned this Mar 11, 2026
@lockwobr lockwobr requested a review from a team as a code owner March 11, 2026 19:39
@lockwobr lockwobr enabled auto-merge (squash) March 11, 2026 19:39
@lockwobr lockwobr merged commit cc4162c into main Mar 11, 2026
15 checks passed
@lockwobr lockwobr deleted the fix/remove-post-install-sandbox-permissions branch March 11, 2026 19:47
@github-actions
Copy link
Copy Markdown

Coverage Report ✅

Metric Value
Coverage 73.3%
Threshold 70%
Status Pass
Coverage Badge
![Coverage](https://img.shields.io/badge/coverage-73.3%25-green)

No Go source files changed in this PR.

xdu31 pushed a commit to xdu31/aicr that referenced this pull request Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants