Skip to content

feat(gke/skyhook): add tuning that can support container optimized OS…#343

Merged
ayuskauskas merged 1 commit intofeat/gke-cos-training-overlaysfrom
feat/gke-cos-training-overlays-skyhook3
Mar 11, 2026
Merged

feat(gke/skyhook): add tuning that can support container optimized OS…#343
ayuskauskas merged 1 commit intofeat/gke-cos-training-overlaysfrom
feat/gke-cos-training-overlays-skyhook3

Conversation

@ayuskauskas
Copy link
Copy Markdown
Contributor

… in GKE

Summary

Motivation / Context

Fixes:
Related:

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • Build/CI/tooling

Component(s) Affected

  • CLI (cmd/aicr, pkg/cli)
  • API server (cmd/aicrd, pkg/api, pkg/server)
  • Recipe engine / data (pkg/recipe)
  • Bundlers (pkg/bundler, pkg/component/*)
  • Collectors / snapshotter (pkg/collector, pkg/snapshotter)
  • Validator (pkg/validator)
  • Core libraries (pkg/errors, pkg/k8s)
  • Docs/examples (docs/, examples/)
  • Other: ____________

Implementation Notes

Testing

# Commands run (prefer `make qualify` for non-trivial changes)
make qualify

Risk Assessment

  • Low — Isolated change, well-tested, easy to revert
  • Medium — Touches multiple components or has broader impact
  • High — Breaking change, affects critical paths, or complex rollout

Rollout notes:

Checklist

  • Tests pass locally (make test with -race)
  • Linter passes (make lint)
  • I did not skip/disable tests to make CI green
  • I added/updated tests for new functionality
  • I updated docs if user-facing behavior changed
  • Changes follow existing patterns in the codebase
  • Commits are cryptographically signed (git commit -S) — GPG signing info

@ayuskauskas ayuskauskas requested a review from a team as a code owner March 11, 2026 19:06
@ayuskauskas ayuskauskas merged commit 641f0b7 into feat/gke-cos-training-overlays Mar 11, 2026
3 checks passed
@ayuskauskas ayuskauskas deleted the feat/gke-cos-training-overlays-skyhook3 branch March 11, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant