fix: rename prometheus component to kube-prometheus-stack#3
Merged
mchmarny merged 1 commit intoNVIDIA:mainfrom Feb 2, 2026
Merged
Conversation
56d3f26 to
ba6c04c
Compare
Member
|
Looks like there will be more work required on this to make it work in CI. @dims @lalitadithya anything we can replicate here form NVS? |
dims
added a commit
to dims/cloud-native-stack
that referenced
this pull request
Jan 31, 2026
Fork PRs have restricted GITHUB_TOKEN permissions that prevent posting comments directly. This change uses the workflow_run pattern: 1. Main workflow uploads coverage data as artifact (read-only safe) 2. Separate workflow_run triggered workflow posts comment (write perms) This is the recommended secure pattern per GitHub Security Lab: https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/ Fixes: NVIDIA/aicr#3 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Davanum Srinivas <dsrinivas@nvidia.com>
25 tasks
dims
added a commit
to dims/aicr
that referenced
this pull request
Jan 31, 2026
Fork PRs have restricted GITHUB_TOKEN permissions that prevent posting comments directly. This change uses the workflow_run pattern: 1. Main workflow uploads coverage data as artifact (read-only safe) 2. Separate workflow_run triggered workflow posts comment (write perms) This is the recommended secure pattern per GitHub Security Lab: https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/ Fixes: NVIDIA/aicr#3 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Davanum Srinivas <dsrinivas@nvidia.com>
0b5b091 to
43c038e
Compare
25 tasks
43c038e to
6c6c199
Compare
Coverage Report ✅
Coverage BadgeCoverage unchanged by this PR. |
dims
approved these changes
Feb 2, 2026
Align component name with Helm chart name to ensure values are correctly passed to the sub-chart in umbrella chart deployments. Changes: - Rename component from 'prometheus' to 'kube-prometheus-stack' in registry - Rename components/prometheus directory to components/kube-prometheus-stack - Update base.yaml overlay to use new component name and values path - Update monitoring-hpa.yaml dependency reference - Keep 'prometheus' in valueOverrideKeys for backwards compatibility Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> fix: rename prometheus component to kube-prometheus-stack Align component name with Helm chart name to ensure values are correctly passed to the sub-chart in umbrella chart deployments. Changes: - Rename component from 'prometheus' to 'kube-prometheus-stack' in registry - Rename components/prometheus directory to components/kube-prometheus-stack - Update base.yaml overlay to use new component name and values path - Update monitoring-hpa.yaml dependency reference - Keep 'prometheus' in valueOverrideKeys for backwards compatibility Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
a6df5f4 to
27afca5
Compare
dims
referenced
this pull request
in dims/aicr
Feb 20, 2026
Add three new validation steps to the H100 inference test: - Inference Gateway (#6): verify GatewayClass accepted and Gateway programmed with inference extension CRDs present - Accelerator & AI Service Metrics (#4/#5): verify DCGM Exporter metrics, Prometheus scraping, and custom metrics API availability - Secure Accelerator Access (#3): verify GPU access is DRA-mediated (no hostPath, no device plugin), with proper container security Also adds diagnostics for gateway, metrics, and DRA state on failure. Signed-off-by: Davanum Srinivas <dsrinivas@nvidia.com>
6 tasks
dims
referenced
this pull request
in dims/aicr
Feb 20, 2026
Add three new validation steps to the H100 inference test: - Inference Gateway (#6): verify GatewayClass accepted and Gateway programmed with inference extension CRDs present - Accelerator & AI Service Metrics (#4/#5): verify DCGM Exporter metrics, Prometheus scraping, and custom metrics API availability - Secure Accelerator Access (#3): verify GPU access is DRA-mediated (no hostPath, no device plugin), with proper container security Also adds diagnostics for gateway, metrics, and DRA state on failure. Signed-off-by: Davanum Srinivas <dsrinivas@nvidia.com>
This was referenced Feb 20, 2026
This was referenced Mar 9, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prometheustokube-prometheus-stackto match the Helm chart nameProblem
The component was named
prometheusbut the Helm chart iskube-prometheus-stack. When generating umbrella charts, the Chart.yaml dependency uses the actual chart name (kube-prometheus-stack), but values were keyed underprometheus:. This mismatch caused Helm values (likefullnameOverride) to not be passed to the sub-chart.Changes
pkg/recipe/data/registry.yaml: Rename component fromprometheustokube-prometheus-stackpkg/recipe/data/components/prometheus/→pkg/recipe/data/components/kube-prometheus-stack/pkg/recipe/data/overlays/base.yaml: Update component name and valuesFile pathpkg/recipe/data/overlays/monitoring-hpa.yaml: Update dependencyRefprometheusinvalueOverrideKeysfor backwards compatibility with--set prometheus:key=valueTest plan
helm installand verify kube-prometheus-stack values are applied correctly--set prometheus:key=valuestill works for backwards compatibility🤖 Generated with Claude Code