Skip to content

Conversation

@chuangz0
Copy link
Collaborator

@chuangz0 chuangz0 commented Dec 8, 2025

Summary by CodeRabbit

  • Chores
    • Updated UCX (collective communications library) version to v1.20.x in Docker configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@chuangz0 chuangz0 requested review from a team as code owners December 8, 2025 10:30
@chuangz0
Copy link
Collaborator Author

chuangz0 commented Dec 8, 2025

/bot run --stage-list "Build-Docker-Images"

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 8, 2025

📝 Walkthrough

Walkthrough

The UCX version specified in a Docker installation script is updated from v1.19.x to v1.20.x, affecting the source checkout branch and subsequent build/install paths.

Changes

Cohort / File(s) Change Summary
Version Update
docker/common/install_ucx.sh
UCX_VERSION constant bumped from v1.19.x to v1.20.x

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is entirely a template with no actual content filled in. Required sections like Description and Test Coverage are empty. Fill in the Description section explaining why UCX is being updated to 1.20, and provide Test Coverage details explaining which tests validate this infrastructure change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title '[None][infra] update ucx to 1.20' accurately summarizes the main change: updating UCX version from 1.19.x to 1.20.x in the Docker configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 96d9b67 and 8d228a4.

📒 Files selected for processing (1)
  • docker/common/install_ucx.sh (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
docker/common/install_ucx.sh (1)

4-4: Verify that v1.20.x pre-release is intentional.

v1.20.0-rc1 was released on Dec 7, 2025, and no stable v1.20.0 release exists yet. Using "v1.20.x" will install a pre-release (release candidate) rather than a stable version. This may introduce stability or compatibility risks in production Docker images.

Confirm whether:

  1. The pre-release version is required for a specific feature or fix.
  2. TensorRT-LLM has been tested with UCX v1.20.0-rc1.
  3. A stable v1.20.0 release is expected imminently and this PR should wait.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27293 [ run ] triggered by Bot. Commit: 8d228a4

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27293 [ run ] completed with state SUCCESS. Commit: 8d228a4
/LLM/main/L0_MergeRequest_PR pipeline #20844 (Partly Tested) completed with status: 'SUCCESS'

@chuangz0 chuangz0 requested a review from a team as a code owner December 9, 2025 03:55
@chuangz0 chuangz0 requested a review from xinhe-nv December 9, 2025 03:55
@chuangz0
Copy link
Collaborator Author

chuangz0 commented Dec 9, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27415 [ run ] triggered by Bot. Commit: 4a64cf8

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27415 [ run ] completed with state SUCCESS. Commit: 4a64cf8
/LLM/main/L0_MergeRequest_PR pipeline #20947 completed with status: 'FAILURE'

@chuangz0
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27585 [ run ] triggered by Bot. Commit: d7ecd5a

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27585 [ run ] completed with state FAILURE. Commit: d7ecd5a
/LLM/main/L0_MergeRequest_PR pipeline #21055 completed with status: 'FAILURE'

@chuangz0
Copy link
Collaborator Author

/bot run

@chuangz0
Copy link
Collaborator Author

/bot run --stage-list "Build-Docker-Images"

@chuangz0 chuangz0 force-pushed the update_ucx_1_20 branch 2 times, most recently from f770ce6 to 48e71e2 Compare December 11, 2025 02:43
@chuangz0
Copy link
Collaborator Author

/bot run --stage-list "Build-Docker-Images"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27780 [ run ] triggered by Bot. Commit: 48e71e2

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27783 [ run ] triggered by Bot. Commit: 48e71e2

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27780 [ run ] completed with state ABORTED. Commit: 48e71e2

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27783 [ run ] completed with state FAILURE. Commit: 48e71e2
/LLM/main/L0_MergeRequest_PR pipeline #21203 (Partly Tested) completed with status: 'FAILURE'

@chuangz0
Copy link
Collaborator Author

/bot run

Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
@tensorrt-cicd
Copy link
Collaborator

PR_Github #27839 [ run ] triggered by Bot. Commit: c115a8a

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27839 [ run ] completed with state SUCCESS. Commit: c115a8a
/LLM/main/L0_MergeRequest_PR pipeline #21250 completed with status: 'SUCCESS'

@Shixiaowei02 Shixiaowei02 merged commit 4670e0c into NVIDIA:main Dec 12, 2025
5 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Dec 14, 2025
1 task
sherry-1001 pushed a commit to sherry-1001/TensorRT-LLM that referenced this pull request Dec 16, 2025
Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
codego7250 pushed a commit to codego7250/TensorRT-LLM that referenced this pull request Dec 19, 2025
Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants