[https://nvbugs/5722653][fix] Fix config file used by disagg_client #9783

JunyiXu-nv · 2025-12-08T09:59:15Z

Summary by CodeRabbit

Release Notes

Tests
- Enhanced test configuration handling to support parameterized config paths, enabling more flexible test scenarios for benchmarking.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Junyi Xu <219237550+JunyiXu-nv@users.noreply.github.com>

JunyiXu-nv · 2025-12-08T09:59:39Z

/bot run

coderabbitai · 2025-12-08T10:02:23Z

📝 Walkthrough

Walkthrough

A test file was updated to parameterize the config file path used in benchmark invocation, replacing an inline path construction with a passed config_file parameter while maintaining the prompts file reference.

Changes

Cohort / File(s)	Summary
Test configuration parameterization `tests/integration/defs/disaggregated/test_disaggregated.py`	Modified `run_disaggregated_benchmark` to use passed `config_file` parameter directly in the client `-c` argument instead of constructing the path inline from `example_dir/disagg_config.yaml`. Prompts file path unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is entirely empty—only the template structure is present with no filled-in sections for Description, Test Coverage, or checklist items completed.	Fill in the Description section explaining what issue was fixed and why, add Test Coverage section listing relevant tests, and complete the PR Checklist items.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title correctly follows the template format with NVBugs ID and [fix] type, and accurately describes the main change of fixing the config file path in disagg_client.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 96d9b67 and 18dc7c3.

📒 Files selected for processing (1)

tests/integration/defs/disaggregated/test_disaggregated.py (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: The code developed for TensorRT-LLM should conform to Python 3.8+
Indent Python code with 4 spaces; do not use tabs
Always maintain the namespace when importing in Python, even if only one class or function from a module is used (e.g., use from package.subpackage import foo and then foo.SomeClass() instead of from package.subpackage.foo import SomeClass)
Python filenames should use snake_case (e.g., some_file.py)
Python class names should use PascalCase (e.g., class SomeClass)
Python function and method names should use snake_case (e.g., def my_awesome_function():)
Python local variable names should use snake_case, with prefix k for variable names that start with a number (e.g., k_99th_percentile = ...)
Python global variables should use upper snake_case with prefix G (e.g., G_MY_GLOBAL = ...)
Python constants should use upper snake_case (e.g., MY_CONSTANT = ...)
Avoid shadowing variables declared in an outer scope in Python
Initialize all externally visible members of a Python class in the constructor
For Python interfaces that may be used outside a file, prefer docstrings over comments
Python comments should be reserved for code within a function, or interfaces that are local to a file
Use Google style docstrings for Python classes and functions, which can be parsed by Sphinx
Python attributes and variables can be documented inline with type and description (e.g., self.x = 5 followed by """<type>: Description of 'x'""" )
Avoid using reflection in Python when functionality can be easily achieved without reflection
When using try-except blocks in Python, limit the except clause to the smallest set of specific errors possible instead of catching all exceptions
When using try-except blocks in Python to handle multiple possible variable types (duck-typing), keep the body of the try as small as possible and use the else block to implement the logic

Files:

tests/integration/defs/disaggregated/test_disaggregated.py

**/*.{cpp,h,cu,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

All TensorRT-LLM Open Source Software code files should contain an NVIDIA copyright header that includes the current year at the top

Files:

tests/integration/defs/disaggregated/test_disaggregated.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Pre-commit Check

🔇 Additional comments (1)

tests/integration/defs/disaggregated/test_disaggregated.py (1)

1597-1598: LGTM! Good fix for config file consistency.

The change correctly uses the config_file parameter instead of constructing the path inline. This ensures the client uses the same configuration as the workers and server, which is essential since config files are dynamically generated with free ports or created as temporary files for different test scenarios.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

tensorrt-cicd · 2025-12-08T10:05:51Z

PR_Github #27291 [ run ] triggered by Bot. Commit: 18dc7c3

tensorrt-cicd · 2025-12-08T18:18:08Z

PR_Github #27291 [ run ] completed with state SUCCESS. Commit: 18dc7c3
/LLM/main/L0_MergeRequest_PR pipeline #20842 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

bo-nv

Please unwaive these tests disaggregated/test_disaggregated.py::test_disaggregated_benchmark_on_diff_backends[*

Signed-off-by: Junyi Xu <219237550+JunyiXu-nv@users.noreply.github.com>

Signed-off-by: JunyiXu-nv <219237550+JunyiXu-nv@users.noreply.github.com>

JunyiXu-nv · 2025-12-09T02:03:46Z

/bot run

tensorrt-cicd · 2025-12-09T02:09:42Z

PR_Github #27389 [ run ] triggered by Bot. Commit: 0dc2000

tensorrt-cicd · 2025-12-09T04:34:41Z

PR_Github #27389 [ run ] completed with state SUCCESS. Commit: 0dc2000
/LLM/main/L0_MergeRequest_PR pipeline #20926 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

…VIDIA#9783) Signed-off-by: Junyi Xu <219237550+JunyiXu-nv@users.noreply.github.com> Signed-off-by: JunyiXu-nv <219237550+JunyiXu-nv@users.noreply.github.com>

[https://nvbugs/5722653][fix] Fix config file used by disagg_client

18dc7c3

Signed-off-by: Junyi Xu <219237550+JunyiXu-nv@users.noreply.github.com>

JunyiXu-nv requested a review from bo-nv December 8, 2025 09:59

bo-nv approved these changes Dec 9, 2025

View reviewed changes

bo-nv reviewed Dec 9, 2025

View reviewed changes

JunyiXu-nv added 2 commits December 9, 2025 01:59

unwaive tests

2d58902

Signed-off-by: Junyi Xu <219237550+JunyiXu-nv@users.noreply.github.com>

Merge branch 'main' into dev-junyi-fix-disagg-client

0dc2000

Signed-off-by: JunyiXu-nv <219237550+JunyiXu-nv@users.noreply.github.com>

JunyiXu-nv enabled auto-merge (squash) December 9, 2025 03:15

JunyiXu-nv merged commit 9089078 into NVIDIA:main Dec 9, 2025
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[https://nvbugs/5722653][fix] Fix config file used by disagg_client #9783

[https://nvbugs/5722653][fix] Fix config file used by disagg_client #9783

Uh oh!

JunyiXu-nv commented Dec 8, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

JunyiXu-nv commented Dec 8, 2025

Uh oh!

coderabbitai bot commented Dec 8, 2025

Walkthrough

Changes

Estimated code review effort

Uh oh!

tensorrt-cicd commented Dec 8, 2025

Uh oh!

tensorrt-cicd commented Dec 8, 2025

Uh oh!

bo-nv left a comment

Uh oh!

JunyiXu-nv commented Dec 9, 2025

Uh oh!

tensorrt-cicd commented Dec 9, 2025

Uh oh!

tensorrt-cicd commented Dec 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[https://nvbugs/5722653][fix] Fix config file used by disagg_client #9783

[https://nvbugs/5722653][fix] Fix config file used by disagg_client #9783

Uh oh!

Conversation

JunyiXu-nv commented Dec 8, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Release Notes

Description

Test Coverage

PR Checklist

GitHub Bot Help

kill

skip

reuse-pipeline

Uh oh!

JunyiXu-nv commented Dec 8, 2025

Uh oh!

coderabbitai bot commented Dec 8, 2025

Walkthrough

Changes

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

tensorrt-cicd commented Dec 8, 2025

Uh oh!

tensorrt-cicd commented Dec 8, 2025

Uh oh!

bo-nv left a comment

Choose a reason for hiding this comment

Uh oh!

JunyiXu-nv commented Dec 9, 2025

Uh oh!

tensorrt-cicd commented Dec 9, 2025

Uh oh!

tensorrt-cicd commented Dec 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JunyiXu-nv commented Dec 8, 2025 •

edited by coderabbitai bot

Loading