fix(test): convert assert.ok to vitest expect in policies.test.js#752
Merged
Conversation
PR #356 added tests using node:assert which is not compatible with the vitest runner. Converts to vitest expect() to fix test-unit on main. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe test file Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
ericksoa
approved these changes
Mar 24, 2026
16 tasks
Ryuketsukami
pushed a commit
to Ryuketsukami/NemoClaw
that referenced
this pull request
Mar 24, 2026
…IDIA#752) PR NVIDIA#356 added tests using node:assert which is not compatible with the vitest runner. Converts to vitest expect() to fix test-unit on main. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alexcode-cc
pushed a commit
to alexcode-cc/NemoClaw
that referenced
this pull request
Mar 24, 2026
…IDIA#752) PR NVIDIA#356 added tests using node:assert which is not compatible with the vitest runner. Converts to vitest expect() to fix test-unit on main. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
HagegeR
pushed a commit
to HagegeR/NemoClaw
that referenced
this pull request
Mar 24, 2026
…IDIA#752) PR NVIDIA#356 added tests using node:assert which is not compatible with the vitest runner. Converts to vitest expect() to fix test-unit on main. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jessesanford
pushed a commit
to jessesanford/NemoClaw
that referenced
this pull request
Mar 24, 2026
…IDIA#752) PR NVIDIA#356 added tests using node:assert which is not compatible with the vitest runner. Converts to vitest expect() to fix test-unit on main. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
4 tasks
jacobtomlinson
pushed a commit
to jacobtomlinson/NemoClaw
that referenced
this pull request
Apr 30, 2026
…IDIA#752) PR NVIDIA#356 added tests using node:assert which is not compatible with the vitest runner. Converts to vitest expect() to fix test-unit on main. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #356 added tests using
node:assertwhich is incompatible with the vitest runner. This breakstest-uniton main and every open PR.Converts
assert.ok()to vitestexpect().toBeTruthy()/expect().toBe().Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit