fix: gate local-model onboarding behind NEMOCLAW_EXPERIMENTAL=1#73
Merged
Conversation
Local inference options (nim-local, vllm, ollama, custom) cause issues for users but the code paths should remain for advanced users and development. This gates them behind NEMOCLAW_EXPERIMENTAL=1 so the default onboarding only presents supported options (build, ncp). Changes: - Plugin CLI (onboard.ts): only show build/ncp in interactive prompt; reject experimental endpoint types via --endpoint without the env var; skip Ollama auto-detection unless experimental - Host CLI (bin/lib/onboard.js): skip vLLM/Ollama auto-detection and hide NIM/Ollama/vLLM/install-Ollama options from the menu unless NEMOCLAW_EXPERIMENTAL=1 - CLI help (cli.ts): update --endpoint help text to note experimental All local code paths still work when NEMOCLAW_EXPERIMENTAL=1 is set. Closes #11 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Instead of hiding local options entirely, show them in both the interactive prompt and host CLI menu but label them as [experimental]. This encourages experimentation while being transparent about what's fully supported. Changes from previous commit: - Plugin CLI: always shows all 5 endpoint options, labels nim-local/ vllm/ollama as [experimental]; --endpoint always accepted with a warning for experimental types - Host CLI: always shows local options in menu with [experimental] label; only auto-selects local providers with NEMOCLAW_EXPERIMENTAL=1 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jessesanford
pushed a commit
to jessesanford/NemoClaw
that referenced
this pull request
Mar 24, 2026
…IA#73) * fix: gate local-model onboarding options behind NEMOCLAW_EXPERIMENTAL=1 Local inference options (nim-local, vllm, ollama, custom) cause issues for users but the code paths should remain for advanced users and development. This gates them behind NEMOCLAW_EXPERIMENTAL=1 so the default onboarding only presents supported options (build, ncp). Changes: - Plugin CLI (onboard.ts): only show build/ncp in interactive prompt; reject experimental endpoint types via --endpoint without the env var; skip Ollama auto-detection unless experimental - Host CLI (bin/lib/onboard.js): skip vLLM/Ollama auto-detection and hide NIM/Ollama/vLLM/install-Ollama options from the menu unless NEMOCLAW_EXPERIMENTAL=1 - CLI help (cli.ts): update --endpoint help text to note experimental All local code paths still work when NEMOCLAW_EXPERIMENTAL=1 is set. Closes NVIDIA#11 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: always show experimental options in onboarding, label them clearly Instead of hiding local options entirely, show them in both the interactive prompt and host CLI menu but label them as [experimental]. This encourages experimentation while being transparent about what's fully supported. Changes from previous commit: - Plugin CLI: always shows all 5 endpoint options, labels nim-local/ vllm/ollama as [experimental]; --endpoint always accepted with a warning for experimental types - Host CLI: always shows local options in menu with [experimental] label; only auto-selects local providers with NEMOCLAW_EXPERIMENTAL=1 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mafueee
pushed a commit
to mafueee/NemoClaw
that referenced
this pull request
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11 — onboarding presented local-model options (vllm, ollama, NIM) without indicating they're experimental, leading to confusing failures for users expecting a polished experience.
Approach: Show all options in the interactive prompts but clearly label local ones as
[experimental]. This encourages experimentation while being transparent. Auto-selection of local providers (the silent misconfiguration path) still requiresNEMOCLAW_EXPERIMENTAL=1.What changed
[experimental]in both name and hint--endpointflagNEMOCLAW_EXPERIMENTAL=1[experimental]labelsNEMOCLAW_EXPERIMENTAL=1(no silent misconfiguration)Example: default interactive prompt
Files changed
nemoclaw/src/commands/onboard.ts— labels, warning on--endpoint, gated auto-detectnemoclaw/src/cli.ts— updated--endpointhelp textbin/lib/onboard.js—[experimental]labels on all local options, gated auto-selectAcceptance criteria from #11
NEMOCLAW_EXPERIMENTAL=1)Test results
All 10 test cases passed (static analysis + Docker integration).
--endpoint vllmwarns "experimental" but continues--endpoint buildproduces no warningNEMOCLAW_EXPERIMENTAL=1NEMOCLAW_EXPERIMENTAL=1[experimental]labelsTotal: 40 assertions, 0 failures