fix: verify nemoclaw is on PATH after install#70
Merged
Conversation
The installer reported success even when nemoclaw wasn't discoverable on PATH, leaving users with "command not found" after a seemingly clean install. Common cause: nvm installs Node.js but the npm global bin directory isn't on PATH in the current shell session. Changes: - Add ensure_nvm_loaded() to reliably source nvm in the current shell - Add refresh_path() to discover and add npm global bin to PATH - Add verify_nemoclaw() that checks the command is callable, and if not, diagnoses the problem and prints actionable remediation steps - Replace `npx nemoclaw onboard` with `nemoclaw onboard` so the onboard step itself proves the command works - Exit non-zero if nemoclaw --help cannot be executed after install Closes #9 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ntime check Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jacobtomlinson
approved these changes
Mar 17, 2026
jacobtomlinson
left a comment
Member
There was a problem hiding this comment.
Confirm nemoclaw is on the path for me after install.
4 tasks
jessesanford
pushed a commit
to jessesanford/NemoClaw
that referenced
this pull request
Mar 24, 2026
The installer reported success even when nemoclaw wasn't discoverable on PATH, leaving users with "command not found" after a seemingly clean install. Common cause: nvm installs Node.js but the npm global bin directory isn't on PATH in the current shell session. Changes: - Add ensure_nvm_loaded() to reliably source nvm in the current shell - Add refresh_path() to discover and add npm global bin to PATH - Add verify_nemoclaw() that checks the command is callable, and if not, diagnoses the problem and prints actionable remediation steps - Replace `npx nemoclaw onboard` with `nemoclaw onboard` so the onboard step itself proves the command works - Exit non-zero if nemoclaw --help cannot be executed after install Closes NVIDIA#9 Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Jacob Tomlinson <jtomlinson@nvidia.com>
mafueee
pushed a commit
to mafueee/NemoClaw
that referenced
this pull request
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9 —
./install.shreported success but leftnemoclawunavailable on PATH, causingcommand not foundafter a clean install.Root cause: When nvm installs Node.js, the npm global bin directory isn't always on PATH in the current shell session.
npm linkandnpm install -gput the binary in the right place, but the shell can't find it. The installer never checked.Changes to
install.sh:\. "$HOME/.nvm/nvm.sh"(fragile)ensure_nvm_loaded()helper that setsNVM_DIRand sources reliablyrefresh_path()discovers npm global bin vianpm config get prefixand adds it to PATH if missingverify_nemoclaw()checkscommand -v nemoclaw, diagnoses the failure, prints actionable remediation steps, exits non-zeronpx nemoclaw onboard(workaround)nemoclaw onboard(proves the command actually works)Failure output example (when npm bin isn't on PATH):
Acceptance criteria from #9
./install.shverifies that thenemoclawexecutable is installed and discoverable onPATHnvm, the installer handles that explicitly or fails with a clear remediation messagenemoclaw --helpcannot be executed after installnpx nemoclawas a workaround — usesnemoclawdirectlyTest results
All 8 test cases passed in Docker containers.
npm linkpath)npxin script, onboard usesnemoclawdirectlyensure_nvm_loadedis idempotent (no PATH dupes)refresh_pathdoesn't duplicate PATH entriesTotal: 24 assertions, 0 failures
Key validations:
npm install -g)npxworkarounds —nemoclaw onboardis called directly, proving the command works