test(e2e): migrate test-rebuild-openclaw.sh to vitest [ANCHOR-7]#5223
Merged
Conversation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a gated Vitest live e2e test (rebuild-openclaw) and a CI job to run it; the test executes a multi-phase rebuild scenario that verifies OpenClaw upgrade, gateway token rotation, policy preset persistence, config-hash updates, and scans rebuild backups for credential leaks. ChangesLive rebuild scenario e2e test
CI: run rebuild-openclaw Vitest scenario
Sequence Diagram(s)sequenceDiagram
participant Vitest as Vitest Runner
participant CLI as nemoclaw CLI
participant Docker as Docker Engine
participant OpenShell as OpenShell Sandbox
participant Registry as Local NemoClaw Registry
Vitest->>CLI: invoke `nemoclaw onboard` / `rebuild`
CLI->>Docker: build/tag sandbox base images
Docker->>OpenShell: start sandbox container (old/new base)
Vitest->>OpenShell: probe readiness and `openclaw --version`
Vitest->>Registry: seed `sandboxes.json` / `onboard-session.json`
Vitest->>CLI: trigger `rebuild` (consumes rebuilt base)
CLI->>Registry: rotate gateway token, update registry agent
CLI->>Docker: produce rebuild backups and manifest
Vitest->>Registry: read local registry JSON for policy/preset verification
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
E2E Advisor RecommendationRequired E2E: Dispatch hint: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
Contributor
Vitest E2E Scenario RecommendationRequired Vitest E2E scenarios: Dispatch required Vitest E2E scenarios:
Full Vitest E2E advisor summaryVitest E2E Scenario AdvisorBase: Required Vitest E2E scenarios
Optional Vitest E2E scenarios
Relevant changed files
|
Contributor
PR Review AdvisorFindings: 1 needs attention, 4 worth checking, 0 nice ideas Review findings🛠️ Needs attention
🔎 Worth checking
🌱 Nice ideas
Consider writing more tests for
Since last review detailsCurrent findings:
This is an automated advisory review. A human maintainer must make the final merge decision. |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/e2e-scenario/live/rebuild-openclaw.test.ts`:
- Around line 129-173: seedRegistryAndSession currently overwrites REGISTRY_FILE
and SESSION_FILE which can delete unrelated user state; instead read existing
registry and session via readJsonFile, merge or upsert only the SANDBOX_NAME
entry into the registry object (preserving other sandboxes and defaultSandbox),
and write back with writeJsonFile; for session, read the existing session, only
set/override keys necessary for the test (sandboxName, status, steps, etc.)
rather than replacing the whole file, or alternatively back up the original
files before writing and restore them in test teardown to ensure no persistent
state is lost.
- Around line 201-230: backupCredentialLeakPaths currently scans all timestamped
backups under BACKUP_ROOT/SANDBOX_NAME causing older backups to trigger false
positives; change it to only scan the specific backup directory for this run
(the latest rebuild manifest directory) instead of sandboxBackupRoot. Locate
backupCredentialLeakPaths and either accept a backupDir argument or compute the
latest backup directory by calling latestRebuildManifest()/the existing resolver
used elsewhere in this test, then replace sandboxBackupRoot with that single
directory and run scan only if that directory exists. Ensure references to
BACKUP_ROOT and SANDBOX_NAME are removed from the scan root so only the intended
timestamped backup is inspected.
- Around line 314-331: The final cleanup block (cleanup.add "destroy rebuilt
sandbox") is missing the step to remove the host-side "nemoclaw" gateway; add a
host.command call that mirrors the earlier pre-cleanup gateway teardown to run
the CLI gateway-destroy for SANDBOX_NAME (e.g., host.command("node",
[CLI_ENTRYPOINT, SANDBOX_NAME, "gateway", "destroy", "--yes"], ...) using the
same cliEnv(apiKey), redactionValues: [apiKey], artifactName like
"cleanup-nemoclaw-gateway-destroy" and an appropriate timeout) before calling
sandbox.delete and docker rmi so the gateway state is not leaked.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: b38b741b-44e3-4db1-8b2b-33c58710d2e5
📒 Files selected for processing (1)
test/e2e-scenario/live/rebuild-openclaw.test.ts
Contributor
Author
|
Updated PR #5223 to address advisor/CodeRabbit feedback:
Validation after changes:
|
…ild-openclaw-simple # Conflicts: # .github/workflows/e2e-vitest-scenarios.yaml
Contributor
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27377306575
|
cv
approved these changes
Jun 11, 2026
Contributor
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27380092380
|
…ild-openclaw-simple # Conflicts: # .github/workflows/e2e-vitest-scenarios.yaml
Contributor
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27380833994
|
Contributor
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27381425202
|
…ild-openclaw-simple # Conflicts: # .github/workflows/e2e-vitest-scenarios.yaml
Contributor
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27381935146
|
…ild-openclaw-simple # Conflicts: # .github/workflows/e2e-vitest-scenarios.yaml
…ild-openclaw-simple
12 tasks
79 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate
test/e2e/test-rebuild-openclaw.shwith focused live Vitest coverage intest/e2e-scenario/live/rebuild-openclaw.test.ts.Related Issues
Refs #5098
Refs #1952
Refs #4517
Contract mapping
rebuild-openclaw.test.tsbuildsDockerfile.basewithOPENCLAW_VERSION=2026.3.11, creates the sandbox withopenshell sandbox create, and verifiesopenclaw --versionreports the old version.nemoclaw <name> rebuild --yes./sandbox/.openclaw/workspace/rebuild-marker.txt, runs the real rebuild CLI, then reads the marker back.node bin/nemoclaw.js <name> rebuild --yes --verbose.openclaw --versionno longer reports2026.3.11and registryagentVersionchanged.~/.nemoclaw/sandboxes.json..config-hashis valid ([Ubuntu 24.04][Sandbox] Gateway token not rotated on sandbox rebuild — ensure_gateway_token is idempotent in v0.0.50+ mutable-default config #4517)./tmp/nemoclaw-proxy-env.shparity, hash change, andsha256sum -cvalidity.~/.nemoclaw/rebuild-backups/<sandbox>JSON/env candidates while pruning lockfiles.npm/pypipolicy presets survive rebuild ([brev]nemoclaw rebuild does not restore Telegram (messaging) policy presets — bridge starts but cannot reach api.telegram.org #1952).policyPresets.openshell policy get --full.Simplicity check
Verification
npm run build:clinpm run typecheck:cli -- --pretty falseNEMOCLAW_RUN_E2E_SCENARIOS=1 npx vitest run --project e2e-scenarios-live test/e2e-scenario/live/rebuild-openclaw.test.ts --silent=false --reporter=default(passes locally with the test skipped because Docker daemon is unavailable; on GitHub Actions the test fails instead of skipping if Docker/OpenShell prerequisites are missing)git diff --checkNotes
pre-commitandpre-pushhooks repeatedly died with signal 9 after the visible checks passed, so the commit/push used--no-verifyafter running the relevant validation manually.Summary by CodeRabbit