feat(cli): add sandbox agents list passthrough#5043
Conversation
Signed-off-by: Tinson Lai <tinsonl@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR adds a new ChangesSandbox agents list command
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
E2E Advisor RecommendationRequired E2E: Dispatch hint: Auto-dispatched E2E: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
E2E Scenario Advisor RecommendationRequired scenario E2E: Dispatch required scenario E2E:
Full scenario advisor summaryE2E Scenario AdvisorBase: Required scenario E2E
Optional scenario E2E
Relevant changed files
|
PR Review AdvisorFindings: 1 needs attention, 0 worth checking, 2 nice ideas Review findings🛠️ Needs attention
🔎 Worth checking
🌱 Nice ideas
Consider writing more tests for
Since last review detailsCurrent findings:
This is an automated advisory review. A human maintainer must make the final merge decision. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/reference/commands.mdx (1)
1141-1141: ⚡ Quick winRewrite in active voice.
The sentence uses passive voice ("are forwarded"). Rewrite as active voice, for example: "The command forwards
--jsonand--bindingsflags accepted by the in-sandbox OpenClaw CLI verbatim."As per coding guidelines, active voice is required in documentation. The relevant rule: "Active voice required. Flag passive constructions."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/reference/commands.mdx` at line 1141, Rewrite the passive sentence to active voice: replace "Flags accepted by the in-sandbox CLI (`--json`, `--bindings`) are forwarded verbatim." with an active construction such as "The command forwards the in-sandbox OpenClaw CLI flags `--json` and `--bindings` verbatim." Update the line containing that sentence (search for the exact phrase "Flags accepted by the in-sandbox CLI (`--json`, `--bindings`) are forwarded verbatim.") and ensure it mentions "the command" and "in-sandbox OpenClaw CLI" as shown.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docs/reference/commands.mdx`:
- Line 1141: Rewrite the passive sentence to active voice: replace "Flags
accepted by the in-sandbox CLI (`--json`, `--bindings`) are forwarded verbatim."
with an active construction such as "The command forwards the in-sandbox
OpenClaw CLI flags `--json` and `--bindings` verbatim." Update the line
containing that sentence (search for the exact phrase "Flags accepted by the
in-sandbox CLI (`--json`, `--bindings`) are forwarded verbatim.") and ensure it
mentions "the command" and "in-sandbox OpenClaw CLI" as shown.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: a5895cf5-79d0-406d-b3bd-ba6d59aa5ea0
📒 Files selected for processing (7)
docs/reference/commands.mdxsrc/commands/sandbox/agents.tssrc/commands/sandbox/agents/list.tssrc/lib/actions/sandbox/agents/passthrough.tssrc/lib/cli/command-registry.test.tssrc/lib/cli/public-display-agents.tstest/e2e/test-sessions-agents-cli.sh
Selective E2E Results — ❌ Some jobs failedRun: 27212582454
|
Signed-off-by: Tinson Lai <tinsonl@nvidia.com>
Signed-off-by: Tinson Lai <tinsonl@nvidia.com>
|
🌿 Preview your docs: https://nvidia-preview-pr-5043.docs.buildwithfern.com/nemoclaw |
Selective E2E Results — ✅ All requested jobs passedRun: 27214282544
|
## Summary - Add v0.0.62 release notes from Discussion #5100 and link release highlights to the relevant docs pages. - Document the release's GPU sandbox recreation, sandbox-side local inference verification, and Hermes dashboard port guard in the command and inference references. - Refresh generated NemoClaw user skills for the release-prep docs set. ## Source Summary - #4956 -> `docs/reference/commands.mdx`: Document CDI-first Docker GPU recreation behavior for Linux Docker-driver sandboxes. - #5024 -> `docs/inference/use-local-inference.mdx`: Document sandbox-runtime verification of the `inference.local` local inference route. - #5018 -> `docs/reference/commands.mdx`: Document Jetson/Tegra device-node group propagation for sandbox CUDA initialization. - #5012, #4763, #4706, #5030, #5015 -> `docs/about/release-notes.mdx`: Summarize onboarding and recovery reliability fixes, including the reserved Hermes API port guard. - #5017 and #5043 -> `docs/about/release-notes.mdx`, `docs/reference/commands.mdx`: Summarize mutable OpenClaw config recovery and host-side `agents list` coverage. - #5010 and #5016 -> `docs/about/release-notes.mdx`: Summarize Hermes upstream metadata visibility and WhatsApp QR rendering reliability. - #5045 and prior source docs in the v0.0.62 range -> `.agents/skills/`: Refresh generated user-skill references from the current docs source. ## Skipped - #5019 -> skipped for new prose because it touched `openclaw-sandbox-permissive.yaml`, which matches `docs/.docs-skip`. Existing source docs remain the source for generated skill synchronization. ## Verification - `python3 scripts/docs-to-skills.py docs/ .agents/skills/ --prefix nemoclaw-user --doc-platform fern-mdx` - `npm run docs` (passes; Fern reports 0 errors and 1 hidden warning) - Pre-commit hooks passed during commit, including docs-to-skills verification, markdown lint, gitleaks, and skills YAML tests. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added `nemoclaw <name> agents list` command. * v0.0.62 release notes added summarizing onboarding and recovery improvements. * **Bug Fixes** * Improved GPU sandbox onboarding reliability (NVIDIA CDI path, Jetson/Tegra device handling). * Better local inference verification and recovery for Linux Docker-driver GPU sandboxes. * Quieter/earlier handling of onboarding drift and port collisions. * **Documentation** * Expanded GPU passthrough, inference verification, writable paths (`/dev/pts`), port 8642 restriction, and command examples. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Prekshi Vyas <34834085+prekshivyas@users.noreply.github.com>
Summary
Adds
nemoclaw <name> agents listas a thin pass-through toopenclaw agents listviaopenshell sandbox exec. This finishes the host-side agent lifecycle surface —addanddeleteshipped in #4615; declarative seeding is already covered by the bake-timeNEMOCLAW_EXTRA_AGENTS_JSONpath from #4560.Related Issue
Closes #2854.
Changes
src/commands/sandbox/agents/list.ts: new oclif command, mirrors thesessions listandagents add/deleteshape.src/lib/actions/sandbox/agents/passthrough.ts:AgentsPassthroughVerbextended to"add" | "delete" | "list"; parent help now lists the third subcommand.src/commands/sandbox/agents.ts: parent examples includeagents list alpha --json.src/lib/cli/public-display-agents.ts: registerssandbox:agents:listunder Sandbox Management at order 16.4 (ahead of add/delete to match lifecycle order).src/lib/cli/command-registry.test.ts: bumps sandbox-command count 43 -> 44 and updates the comment from "agents pair" to "agents trio".docs/reference/commands.mdx: new### nemoclaw <name> agents listsection before the existingaddentry.test/e2e/test-sessions-agents-cli.sh: newTC-AGENT-03between add and delete; callsagents list --jsonand asserts the seeded agent appears in the listing.Out of Scope
agents apply -ffrom the original design is dropped — per-entryagents add(shipped via #4615) already covers operator workflows, andNEMOCLAW_EXTRA_AGENTS_JSON(shipped via #4560) already handles declarative bake-time seeding. No upstreamopenclaw agents applyverb oragents.applygateway RPC exists, so a host-side reconcile would also need a newagents updateCLI verb upstream first.Type of Change
Verification
npx prek run --all-filespassesnpm testpassesnpm run docsbuilds without warnings (doc changes only)Signed-off-by: Tinson Lai tinsonl@nvidia.com
Summary by CodeRabbit
New Features
Documentation
Tests