test(e2e): make framework test names readable#5035
Merged
Conversation
Contributor
|
Warning Review limit reached
More reviews will be available in 8 minutes and 15 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (15)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
PR Review AdvisorFindings: 0 needs attention, 0 worth checking, 0 nice ideas This is an automated advisory review. A human maintainer must make the final merge decision. |
Contributor
E2E Advisor RecommendationRequired E2E: Dispatch hint: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
Contributor
E2E Scenario Advisor RecommendationRequired scenario E2E: Dispatch required scenario E2E:
Full scenario advisor summaryE2E Scenario AdvisorBase: Required scenario E2E
Optional scenario E2E
Relevant changed files
|
jyaunches
added a commit
that referenced
this pull request
Jun 9, 2026
Stack PRs 4941/4990 stack-01/02/03 were squash-merged into main as #5003, #5004, #5035; merging main resolves the resulting add/add and content conflicts by taking main's versions for already-merged files. Only the 3 new files from 93fb874 remain: runtime-support.ts, registry-scenarios.test.ts, and e2e-live-registry-discovery.test.ts. Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
jyaunches
added a commit
that referenced
this pull request
Jun 9, 2026
Resolves divergence with parent stack PRs (#5002, #5003, #5004, #5005) already merged into main, plus #5022 and #5035 refinements. Conflict resolution prefers main's canonical phase-fixture and framework-plumbing files (those have already received post-#5005 refactors), and re-applies this PR's unique deltas on top: - liveScenarioTestName() helper in runtime-support.ts - Skip-name realignment + module-load [not wired] log in registry-scenarios.test.ts - New e2e-live-skip-name-contract framework test Net effect of this PR vs main is the matrix fan-out workflow, --emit-live-matrix CLI, workflow boundary updates, and the filter-alignment fix. See `git diff origin/main` for the full delta. Co-authored-by: Julie Yaunches <jyaunches@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the E2E scenario framework Vitest output readable by replacing snake_case
describe/itnames with sentence-style labels. This keeps machine-oriented scenario, assertion, and helper IDs unchanged while making test output easier to scan.Changes
seedContextEnv,secretEnv, and product/env concepts expressed in prose.Type of Change
Verification
Focused checks passed:
npx vitest run --project e2e-scenario-frameworknpx vitest run --project cli test/cli/list-inference.test.ts test/cli/list-share-live-inference.test.ts test/cli/sandbox-mutations.test.tsnpx vitest run --project cli test/e2e-scenario/framework-tests/e2e-fixture-context.test.tsnpx vitest run --project e2e-scenario-framework test/e2e-scenario/framework-tests/e2e-fixture-context.test.tsNotes:
npm testpassed once before the final one-line wording tweak. A later full retry hit unrelated 5s CLI dispatch timeouts, and the three failed files passed when rerun directly. A laternpx prek run --all-filesretry hit an unrelated signal-timing assertion ine2e-fixture-context.test.ts, and that file passed when rerun directly under both affected projects.npx prek run --all-filespassesnpm testpassesnpm run docsbuilds without warnings (doc changes only)Signed-off-by: Carlos Villela cvillela@nvidia.com