Fail fast on unsupported installer runtimes#43
Merged
Conversation
ericksoa
approved these changes
Mar 17, 2026
ericksoa
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Verified all four acceptance criteria from #10 are met: preflight checks in both installers, clear fail-fast error message with detected + required versions, README prerequisites updated, and regression test covers Node 18 + npm 9. One minor note: root install.sh skips upgrade if Node exists (even if 18) while scripts/install.sh actively installs 22 — not a blocker, just worth knowing.
jessesanford
pushed a commit
to jessesanford/NemoClaw
that referenced
this pull request
Mar 24, 2026
Fail fast on unsupported installer runtimes
mafueee
pushed a commit
to mafueee/NemoClaw
that referenced
this pull request
Mar 28, 2026
## Summary - add a Docker-based macOS arm64 wheel build path so darwin wheels can be produced from Linux CI hosts - wire macOS wheel builds into release publish workflows (`publish:main` and `publish:tag`) alongside existing Linux wheel builds - mirror `crazymax/osxcross:latest` into `$CI_REGISTRY_IMAGE/third_party/osxcross:latest` and use that mirrored image in CI publish jobs ## Scope Notes - this MR focuses on shipping reliable macOS wheel build support first - temporary MR-only smoke-job wiring was removed after validation so the branch reflects final intended CI behavior - broader cache optimization work is tracked separately in issue NVIDIA#43 ## Test Plan - run `mise run pre-commit` - validate `.gitlab-ci.yml` with `uv run --with pyyaml python -c 'import yaml, pathlib; yaml.safe_load(pathlib.Path(".gitlab-ci.yml").read_text())'`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linked issue
Fixes #10
Verification
npm test