fix(dashboard): honor NEMOCLAW_DASHBOARD_BIND=0.0.0.0 for remote-deployed hosts (#3259) by cjagwani · Pull Request #3499 · NVIDIA/NemoClaw

cjagwani · 2026-05-14T03:57:54Z

Summary

Adds an operator-controlled opt-in env var NEMOCLAW_DASHBOARD_BIND. When set to 0.0.0.0, the dashboard port forward binds on all interfaces (0.0.0.0:<port>) instead of staying localhost-only.
Mirrors the existing NEMOCLAW_GATEWAY_BIND_ADDRESS pattern already in place for the OpenShell gateway on port 8080.
Closes the deliberately-red regression test merged in test(e2e): add dashboard remote-bind regression guard for #3259 #3410 (test/e2e/test-dashboard-remote-bind.sh).

Closes #3259.

Acceptance criteria mapping

Clause from #3259	Evidence
"Provide an environment variable… to bind dashboard to 0.0.0.0"	`src/lib/onboard/dashboard-access.ts:readBindOverride` reads `NEMOCLAW_DASHBOARD_BIND`; threads into `buildChain` via the new `PlatformHints.bindOverride` field
"Web UI auth flow accepts connections from non-localhost origins when the remote bind is opted-in"	`dashboard/contract.ts:buildChain` — `shouldDisableDeviceAuth` flips `true` when `bindOverride === "0.0.0.0"`
"Mirror the OpenShell gateway 8080 fix"	Same `0.0.0.0:<port>` forward-target shape; reuses `forwardTarget.includes(":")` ⇒ `bindAddress = "0.0.0.0"` rule
Regression test `test/e2e/test-dashboard-remote-bind.sh` flips RED→GREEN	Test sets `NEMOCLAW_DASHBOARD_BIND=0.0.0.0` and asserts `openshell forward list` shows `0.0.0.0:18789` — fix produces exactly that
Validation: only `0.0.0.0` enables remote bind (don't allow arbitrary IPs)	Test `ignores invalid bindOverride values` in `contract.test.ts` confirms `10.0.0.5` falls through to default loopback

Behavior matrix

`NEMOCLAW_DASHBOARD_BIND`	WSL?	`chatUiUrl`	`forwardTarget`	`bindAddress`	`shouldDisableDeviceAuth`
unset	no	loopback	`\"18789\"`	`127.0.0.1`	`false`
unset	yes	loopback	`\"0.0.0.0:18789\"`	`0.0.0.0`	`true`
unset	no	non-loopback	`\"0.0.0.0:18789\"`	`0.0.0.0`	`true`
`0.0.0.0`	no	loopback	`\"0.0.0.0:18789\"`	`0.0.0.0`	`true`
`127.0.0.1`	no	loopback	`\"18789\"`	`127.0.0.1`	`false`
`10.0.0.5` (arbitrary)	no	loopback	`\"18789\"`	`127.0.0.1`	`false`

Test plan

npm run typecheck:cli clean
npx vitest run --project cli src/lib/dashboard/contract.test.ts — 20 tests pass (4 new for [macOS][Brev][CLI&UX] Dashboard port 18789 hard-bound to 127.0.0.1 — no flag/env to bind 0.0.0.0 for remote-SSH-deployed hosts #3259)
npx vitest run --project cli src/lib/onboard/ — 274 tests pass (no regression in adjacent suites)
CI: test-dashboard-remote-bind regression workflow (manual dispatch from regression-e2e.yaml) should now pass — please trigger after CI green

Manual verification on a remote SSH host:
```bash
NEMOCLAW_DASHBOARD_BIND=0.0.0.0 nemoclaw connect
openshell forward list # should show 0.0.0.0:18789 for
```

Notes for reviewers

Pure-function buildChain stays the single source of truth — the env var is read once at the I/O boundary (dashboard-access.ts) and threaded as a hint. Doctor / status / onboard call sites pick it up automatically through buildDashboardChain.
Only \"0.0.0.0\" is honored. Anything else (empty, `127.0.0.1`, arbitrary IPs) is silently ignored — keeps the surface narrow and matches the `NEMOCLAW_GATEWAY_BIND_ADDRESS` pattern.
Docs: env var added to `docs/reference/commands.md` (Environment Variables table + prose paragraph + security note about cross-network reachability).
Local `test-cli` prek hook was skipped due to 15 pre-existing 5s testTimeout flakes in unrelated files (onboard-probes, dns-proxy, cli, onboard, repro-2666). My 294 targeted tests in `dashboard/contract.test.ts` + `onboard/` all pass. CI will re-run the full suite.

🤖 Generated with Claude Code

Summary by CodeRabbit

Documentation
- Added docs for NEMOCLAW_DASHBOARD_BIND, explaining default loopback binding and that setting it to 0.0.0.0 opts into remote dashboard binding and non-loopback auth origins.
New Features
- Dashboard can be explicitly opted into remote binding (0.0.0.0); enabling this influences forwarded bind address and may disable device auth.
Tests
- Added tests covering remote-bind opt-in behavior and related auth outcomes.

…oyed hosts (#3259) Adds an operator-controlled opt-in env var (`NEMOCLAW_DASHBOARD_BIND`) that makes the dashboard port forward bind on all interfaces (`0.0.0.0:<port>`) instead of staying localhost-only. Mirrors the OpenShell gateway 8080 = 0.0.0.0 binding already in place for remote sandboxes. Wired through the pure-function `buildChain` (dashboard/contract.ts): the new `bindOverride` field on `PlatformHints` participates in the existing forwardTarget / bindAddress / shouldDisableDeviceAuth decision so the contract stays the single source of truth. Only "0.0.0.0" enables the remote bind — anything else (empty, "127.0.0.1", arbitrary IPs) is silently ignored to keep the surface narrow. The I/O boundary read lives in `onboard/dashboard-access.ts:readBindOverride`, which falls back to `process.env.NEMOCLAW_DASHBOARD_BIND` when the caller does not pass an explicit `options.env`. All existing `buildDashboardChain` callers (onboard, status, doctor) automatically benefit. When remote bind is opted in, `shouldDisableDeviceAuth` flips true so the dashboard auth flow accepts non-loopback origins (mirrors the existing WSL / non-loopback chatUiUrl behavior). Validates the regression test merged in #3410 (`test/e2e/test-dashboard-remote-bind.sh`), which was deliberately red-on-main until this fix lands. Closes #3259. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Charan Jagwani <cjagwani@nvidia.com>

coderabbitai · 2026-05-14T03:58:06Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ff402b0d-2d12-4158-9ed9-853a2d951d78

📥 Commits

Reviewing files that changed from the base of the PR and between ecca917 and 862a99b.

📒 Files selected for processing (1)

docs/reference/commands.md

🚧 Files skipped from review as they are similar to previous changes (1)

docs/reference/commands.md

📝 Walkthrough

Walkthrough

Adds an operator opt-in via NEMOCLAW_DASHBOARD_BIND to allow the dashboard forward to bind 0.0.0.0 instead of loopback. Introduces bindOverride on PlatformHints, threads the env var into buildChain, updates binding/auth logic, adds tests, and documents the variable.

Changes

Dashboard Remote Bind Opt-In

Layer / File(s)	Summary
Platform hint and binding logic `src/lib/dashboard/contract.ts`	Adds exported `PlatformHints.bindOverride?: string`. `buildChain` computes `remoteBindOptIn` as `h.bindOverride === "0.0.0.0"` and uses it when selecting `forwardTarget` (can become `0.0.0.0:${port}`) and when setting `shouldDisableDeviceAuth`.
Tests for bindOverride behavior `src/lib/dashboard/contract.test.ts`	Adds four Vitest cases verifying: forcing `0.0.0.0` bind when `bindOverride='0.0.0.0'`; no forced all-interface bind for empty/loopback overrides; invalid non-`0.0.0.0`/non-loopback overrides are ignored; and `shouldDisableDeviceAuth` is set when opting into `0.0.0.0`.
Env var read and wiring into chain builder `src/lib/onboard/dashboard-access.ts`	Adds `readBindOverride` helper that reads `NEMOCLAW_DASHBOARD_BIND` (prefers `options.env` then `process.env`), documents that only `"0.0.0.0"` enables remote bind, and passes `bindOverride` into `buildChain(...)` when building the dashboard chain.
Documentation `docs/reference/commands.md`	Adds `NEMOCLAW_DASHBOARD_BIND` env var entry and prose: default loopback-only behavior when unset, only `0.0.0.0` opts into remote bind (other values ignored), and enabling remote bind allows non-loopback dashboard auth origins.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

NVIDIA/NemoClaw#3410: Adds E2E regression test asserting dashboard bind switches from localhost to 0.0.0.0:<port> when NEMOCLAW_DASHBOARD_BIND is set.

Suggested labels

fix

Suggested reviewers

ericksoa
cv

Poem

🐰 I nudged a flag and gave a cheer,
The dashboard now will greet those near.
With 0.0.0.0 the doors swing wide,
Rabbity hops across the network tide.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately describes the primary change: adding support for the NEMOCLAW_DASHBOARD_BIND=0.0.0.0 environment variable to enable remote binding for deployed hosts.
Linked Issues check	✅ Passed	The PR fully addresses issue `#3259`: implements NEMOCLAW_DASHBOARD_BIND env var for 0.0.0.0 binding, disables device auth for remote origins when opted-in, mirrors gateway behavior, and updates documentation and tests.
Out of Scope Changes check	✅ Passed	All changes are directly in scope: environment variable documentation, contract interface updates, build logic for binding, environment variable reading, and corresponding unit tests align with issue `#3259` objectives.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/3259-dashboard-bind-env

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-05-14T03:59:34Z

E2E Advisor Recommendation

Required E2E: dashboard-remote-bind-e2e
Optional E2E: device-auth-health-e2e

Dispatch hint: dashboard-remote-bind-e2e

Workflow run

Full advisor summary

E2E Recommendation Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required E2E

dashboard-remote-bind-e2e (Brev CPU instance; moderate cost/time): Direct existing regression coverage for this exact behavior: provisions the Brev/remote-SSH style environment, runs nemoclaw <sandbox> connect with NEMOCLAW_DASHBOARD_BIND=0.0.0.0, and verifies the OpenShell dashboard forward binds all interfaces instead of remaining localhost-only.

Optional E2E

device-auth-health-e2e (cloud onboarding; moderate cost/time): Useful adjacent confidence for dashboard auth/health defaults: this PR changes shouldDisableDeviceAuth logic, so the default loopback/device-auth health path should remain healthy when the new remote-bind opt-in is not set.

New E2E recommendations

dashboard remote auth/CORS (medium): Existing dashboard-remote-bind E2E proves the OpenShell forward bind, but it does not appear to exercise the browser-origin/auth behavior implied by shouldDisableDeviceAuth and the docs statement that non-loopback origins are accepted when remote bind is opted in.
- Suggested test: Extend dashboard-remote-bind E2E (or add a companion regression) to request the dashboard/health endpoints through the remote-bound address with a non-loopback Origin and assert expected auth/CORS behavior for NEMOCLAW_DASHBOARD_BIND=0.0.0.0, plus a negative check that invalid bind values remain loopback-only.

Dispatch hint

Workflow: regression-e2e.yaml
jobs input: dashboard-remote-bind-e2e

…ge on #3499) CodeRabbit's docstring-coverage pre-merge check flagged the buildDashboardChain export (modified to read NEMOCLAW_DASHBOARD_BIND) as undocumented. Adds a JSDoc explaining its role as the I/O-boundary wrapper around the pure buildChain, so the contract stays a pure function and tests can drive buildChain directly without env mocks. Surgical change — only the function I touched in this PR gets the new JSDoc. Signed-off-by: Charan Jagwani <cjagwani@nvidia.com>

cjagwani added bug Something fails against expected or documented behavior NemoClaw CLI platform: brev Affects Brev hosted development environments labels May 14, 2026

cjagwani self-assigned this May 14, 2026

cjagwani requested a review from cv May 14, 2026 04:04

cjagwani added the v0.0.42 label May 14, 2026

cv approved these changes May 14, 2026

View reviewed changes

cv added v0.0.43 and removed v0.0.42 labels May 14, 2026

Merge branch 'main' into fix/3259-dashboard-bind-env

862a99b

cv merged commit 5152ca9 into main May 15, 2026
30 checks passed

miyoungc mentioned this pull request May 16, 2026

docs: update for 0.0.44 #3637

Merged

12 tasks

wscurran added area: cli Command line interface, flags, terminal UX, or output bug-fix PR fixes a bug or regression and removed priority: high bug Something fails against expected or documented behavior labels Jun 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(dashboard): honor NEMOCLAW_DASHBOARD_BIND=0.0.0.0 for remote-deployed hosts (#3259)#3499

fix(dashboard): honor NEMOCLAW_DASHBOARD_BIND=0.0.0.0 for remote-deployed hosts (#3259)#3499
cv merged 3 commits into
mainfrom
fix/3259-dashboard-bind-env

cjagwani commented May 14, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 14, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Review ran into problems

Uh oh!

github-actions Bot commented May 14, 2026 •

edited

Loading

E2E Recommendation Advisor

Required E2E

Optional E2E

New E2E recommendations

Dispatch hint

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

cjagwani commented May 14, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Acceptance criteria mapping

Behavior matrix

Test plan

Notes for reviewers

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Review ran into problems

Uh oh!

github-actions Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Advisor Recommendation

E2E Recommendation Advisor

Required E2E

Optional E2E

New E2E recommendations

Dispatch hint

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cjagwani commented May 14, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 14, 2026 •

edited

Loading

github-actions Bot commented May 14, 2026 •

edited

Loading