src/lib/inference/ollama/windows.ts (1)

149-172: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Watcher launch failure should fall back to installedPath before failing

When both paths exist, Line 149 gives watcher priority; if that launch fails (Lines 166-172), the function returns false immediately and never attempts the verified installedPath. This can still bounce onboarding back to provider selection on stale watcher-path systems.

Suggested fix

 function launchAndAwaitWindowsOllama(
   opts: { watcherPath?: string; installedPath?: string } = {},
 ): boolean {
   console.log("  Starting Ollama on Windows host via WSL interop...");
   const watcherPath = typeof opts.watcherPath === "string" ? opts.watcherPath.trim() : "";
   const installedPath = typeof opts.installedPath === "string" ? opts.installedPath.trim() : "";
-  let launchScript: string;
-  if (watcherPath) {
-    launchScript =
-      `$env:OLLAMA_HOST='0.0.0.0:11434'; Start-Process -FilePath ${psSingleQuote(watcherPath)} ` +
-      "-WindowStyle Hidden";
-  } else if (installedPath) {
-    launchScript =
-      `$env:OLLAMA_HOST='0.0.0.0:11434'; Start-Process -FilePath ${psSingleQuote(installedPath)} ` +
-      "-ArgumentList 'serve' -WindowStyle Hidden";
-  } else {
-    launchScript =
-      "$env:PATH = [Environment]::GetEnvironmentVariable('PATH','Machine') + ';' + [Environment]::GetEnvironmentVariable('PATH','User'); " +
-      "$env:OLLAMA_HOST='0.0.0.0:11434'; Start-Process -FilePath ollama.exe -ArgumentList serve -WindowStyle Hidden";
-  }
-  const result = run(["powershell.exe", "-Command", launchScript], {
-    ignoreError: true,
-    suppressOutput: true,
-  });
-  if (result.status !== 0) {
-    const stderr = String(result.stderr || "").trim();
-    console.error(
-      `  PowerShell launch failed (exit ${result.status})${stderr ? `: ${stderr}` : ""}`,
-    );
-    return false;
-  }
-  return awaitWindowsOllamaReady();
+  const launchScripts: string[] = [];
+  if (watcherPath) {
+    launchScripts.push(
+      `$env:OLLAMA_HOST='0.0.0.0:11434'; Start-Process -FilePath ${psSingleQuote(watcherPath)} -WindowStyle Hidden`,
+    );
+  }
+  if (installedPath) {
+    launchScripts.push(
+      `$env:OLLAMA_HOST='0.0.0.0:11434'; Start-Process -FilePath ${psSingleQuote(installedPath)} -ArgumentList 'serve' -WindowStyle Hidden`,
+    );
+  }
+  if (launchScripts.length === 0) {
+    launchScripts.push(
+      "$env:PATH = [Environment]::GetEnvironmentVariable('PATH','Machine') + ';' + [Environment]::GetEnvironmentVariable('PATH','User'); " +
+        "$env:OLLAMA_HOST='0.0.0.0:11434'; Start-Process -FilePath ollama.exe -ArgumentList serve -WindowStyle Hidden",
+    );
+  }
+
+  for (const launchScript of launchScripts) {
+    const result = run(["powershell.exe", "-Command", launchScript], {
+      ignoreError: true,
+      suppressOutput: true,
+    });
+    if (result.status === 0 && awaitWindowsOllamaReady()) {
+      return true;
+    }
+  }
+  return false;
 }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/lib/inference/ollama/windows.ts` around lines 149 - 172, The current
logic gives watcherPath priority and returns false on its launch failure,
skipping a possible fallback to installedPath; change the sequence in the block
that builds launchScript and calls run so that if watcherPath is present you
attempt launching it first (using the existing watcherPath launchScript and run
call) but if that run returns a non-zero status and installedPath is available,
rebuild launchScript for installedPath and call run again; only return false if
both attempts fail (preserve the same error logging using result.stderr), and
keep the original behavior when only installedPath or neither path exists.