fix(hermes): restore share-mount package parity#2997
Merged
Conversation
Signed-off-by: Suryaansh <Suryaansh.aa@gmail.com>
Contributor
📝 WalkthroughWalkthroughThe PR adds missing system packages ( ChangesDockerfile and Dependency Test
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Review rate limit: 9/10 reviews remaining, refill in 6 minutes. Comment |
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
agents/hermes/Dockerfile.base (1)
32-46: Run the Hermes e2e pair for this base-image dependency change.This edit is in
agents/hermes/**, so validating with both onboarding and rebuild Hermes e2e flows is the right operational guardrail before merge.As per coding guidelines:
agents/hermes/**changes should runhermes-e2eandrebuild-hermes-e2e.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@agents/hermes/Dockerfile.base` around lines 32 - 46, This change updates base-image packages in the Hermes Dockerfile; before merging, run the Hermes end-to-end validations: execute the hermes-e2e onboarding flow and the rebuild-hermes-e2e flow to verify the updated dependencies; if either fails, capture logs, revert or adjust the package versions in Dockerfile.base (the RUN apt-get ... block) and iterate until both hermes-e2e and rebuild-hermes-e2e pass.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@agents/hermes/Dockerfile.base`:
- Around line 32-46: This change updates base-image packages in the Hermes
Dockerfile; before merging, run the Hermes end-to-end validations: execute the
hermes-e2e onboarding flow and the rebuild-hermes-e2e flow to verify the updated
dependencies; if either fails, capture logs, revert or adjust the package
versions in Dockerfile.base (the RUN apt-get ... block) and iterate until both
hermes-e2e and rebuild-hermes-e2e pass.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 71d884c1-aa28-4bd5-a10a-e96b43fe6640
📒 Files selected for processing (2)
agents/hermes/Dockerfile.basetest/hermes-share-mount-deps.test.ts
Contributor
Selective E2E Results — ✅ All requested jobs passedRun: 25338232939
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gnupg,procps, andopenssh-sftp-serverpackages toagents/hermes/Dockerfile.base, matching the main sandbox base image package contract.apt-get, so the source-shape budget stays at zero.Attribution
This is a maintainer replay of #2975 for issue #2947 because the original contributor branch is cross-repo and not maintainer-writable. The original author and Signed-off-by trailer are preserved on the replay commit; the maintainer adjustment is limited to the test shape required by CI.
Closes #2947
Replaces #2975
Verification
./node_modules/.bin/vitest run test/hermes-share-mount-deps.test.ts./node_modules/.bin/vitest run test/sandbox-provisioning.test.ts test/hermes-share-mount-deps.test.ts src/lib/share-command.test.tsnpm run source-shape:checknpm run typecheck:cligit diff --check origin/main...HEADSummary by CodeRabbit
Chores
Tests