Skip to content

fix(onboard): skip Brave prompt for Hermes#2859

Merged
ericksoa merged 2 commits into
mainfrom
fix/hermes-skip-brave-onboard
May 1, 2026
Merged

fix(onboard): skip Brave prompt for Hermes#2859
ericksoa merged 2 commits into
mainfrom
fix/hermes-skip-brave-onboard

Conversation

@ericksoa

@ericksoa ericksoa commented May 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • explicitly disables the NemoClaw Brave Web Search prompt when the selected agent is Hermes
  • keeps Dockerfile-based web-search detection for Brave-capable agents such as OpenClaw
  • updates onboard helper coverage so a Hermes custom Dockerfile does not accidentally re-enable the Brave prompt

Testing

Summary by CodeRabbit

  • Bug Fixes
    • Hermes agent no longer reports or offers web-search capability in the onboarding flow, so Brave web-search configuration will not be presented for Hermes. Related tests have been updated to reflect this behavior. No public APIs or exported interfaces were changed.

@coderabbitai

coderabbitai Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The web-search capability detection now explicitly returns false for the hermes agent in agentSupportsWebSearch. A test was updated to expect Hermes does not support web search even when a custom Dockerfile ARG suggests otherwise.

Changes

Cohort / File(s) Summary
Web-search capability gating
src/lib/onboard.ts, test/onboard.test.ts
Short-circuits agentSupportsWebSearch for agent.name === "hermes" to always return false; test #2433 updated to assert Hermes reports web-search unsupported despite Dockerfile ARG overrides.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 I hopped through code with careful paws,
I found a gate and changed its laws,
Hermes now skips the searchy quest,
Tests nod gently — it's for the best. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(onboard): skip Brave prompt for Hermes' directly and accurately describes the main change: preventing the Brave web-search prompt from appearing for the Hermes agent.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/hermes-skip-brave-onboard

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/lib/onboard.ts (1)

1530-1567: Consider running the onboarding E2E suite for this gate change.

Since this touches core onboarding flow, it’s worth running the targeted E2Es (cloud-e2e, sandbox-operations-e2e, rebuild-openclaw-e2e) before merge.

As per coding guidelines: src/lib/onboard.ts: “This file contains core onboarding logic… E2E test recommendation: cloud-e2e, sandbox-operations-e2e, rebuild-openclaw-e2e.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/lib/onboard.ts` around lines 1530 - 1567, This change modifies core
onboarding behavior in agentSupportsWebSearch/configureWebSearch and must be
validated by running the recommended E2E suites; please run cloud-e2e,
sandbox-operations-e2e, and rebuild-openclaw-e2e against this branch (or add
them to CI for this PR), verify onboarding flow for agents including hermes and
OpenClaw Brave provider paths, and update the PR description with the E2E
results (or attach failing logs) so we have coverage before merging.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/lib/onboard.ts`:
- Around line 1530-1567: This change modifies core onboarding behavior in
agentSupportsWebSearch/configureWebSearch and must be validated by running the
recommended E2E suites; please run cloud-e2e, sandbox-operations-e2e, and
rebuild-openclaw-e2e against this branch (or add them to CI for this PR), verify
onboarding flow for agents including hermes and OpenClaw Brave provider paths,
and update the PR description with the E2E results (or attach failing logs) so
we have coverage before merging.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b7a1323d-0d4d-4115-a7f1-4eb60795aa2d

📥 Commits

Reviewing files that changed from the base of the PR and between ac68e34 and 8c21ee0.

📒 Files selected for processing (2)
  • src/lib/onboard.ts
  • test/onboard.test.ts

@ericksoa ericksoa self-assigned this May 1, 2026
@ericksoa ericksoa added v0.0.33 integration: hermes Hermes integration behavior labels May 1, 2026
@ericksoa ericksoa requested a review from cv May 1, 2026 22:15
@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

Selective E2E Results — ✅ All requested jobs passed

Run: 25234837342
Branch: fix/hermes-skip-brave-onboard
Requested jobs: cloud-e2e,sandbox-operations-e2e,rebuild-openclaw-e2e
Summary: 3 passed, 0 failed, 19 skipped

Job Result
cloud-e2e ✅ success
cloud-inference-e2e ⏭️ skipped
cloud-onboard-e2e ⏭️ skipped
deployment-services-e2e ⏭️ skipped
diagnostics-e2e ⏭️ skipped
docs-validation-e2e ⏭️ skipped
gpu-e2e ⏭️ skipped
hermes-e2e ⏭️ skipped
inference-routing-e2e ⏭️ skipped
messaging-compatible-endpoint-e2e ⏭️ skipped
messaging-providers-e2e ⏭️ skipped
network-policy-e2e ⏭️ skipped
overlayfs-autofix-e2e ⏭️ skipped
rebuild-hermes-e2e ⏭️ skipped
rebuild-openclaw-e2e ✅ success
sandbox-operations-e2e ✅ success
sandbox-survival-e2e ⏭️ skipped
shields-config-e2e ⏭️ skipped
skill-agent-e2e ⏭️ skipped
snapshot-commands-e2e ⏭️ skipped
token-rotation-e2e ⏭️ skipped
upgrade-stale-sandbox-e2e ⏭️ skipped

@ericksoa ericksoa merged commit 4df8be6 into main May 1, 2026
55 checks passed
cv pushed a commit that referenced this pull request May 2, 2026
## Summary
Daily release-prep documentation refresh for merged PRs from the past 24
hours.
This updates user-facing docs for Telegram mention-only mode, in-sandbox
messaging shutdown, Hermes onboarding/runtime behavior, and
compatible-endpoint smoke validation, then bumps the docs metadata to
0.0.33 after tag v0.0.32.

## Related Issue
None.

## Changes
- #2417 / c7e49ad: Document `TELEGRAM_REQUIRE_MENTION` for Telegram
group-chat replies in `docs/manage-sandboxes/messaging-channels.md` and
`docs/reference/commands.md`.
- #1977 / 69403e0: Update `nemoclaw tunnel stop` and deprecated
`nemoclaw stop` docs to explain that NemoClaw also attempts to stop the
in-sandbox OpenClaw gateway and messaging polling.
- #2781 / b83ffe2, #2859 / 4df8be6, and #2846 / 0968dfd: Refresh the
Hermes quickstart for the default `my-hermes` sandbox name, cross-agent
same-name guard, agent type visibility in `nemoclaw list`, Brave prompt
omission, and supported prebaked Hermes integrations.
- #2849 / fd240ff: Document the Telegram plus OpenAI-compatible
endpoint `inference.local` smoke check in inference options and
troubleshooting.
- Bump `docs/versions1.json` and `docs/project.json` from 0.0.32 to
0.0.33 for daily release preparation.

## Type of Change
- [ ] Code change (feature, bug fix, or refactor)
- [ ] Code change with doc updates
- [ ] Doc only (prose changes, no code sample modifications)
- [x] Doc only (includes code sample changes)

## Verification
- [ ] `npx prek run --all-files` passes
- [ ] `npm test` passes
- [ ] Tests added or updated for new or changed behavior
- [x] No secrets, API keys, or credentials committed
- [x] Docs updated for user-facing behavior changes
- [x] `make docs` builds without warnings (doc changes only)
- [x] Doc pages follow the [style
guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md)
(doc changes only)
- [ ] New doc pages include SPDX header and frontmatter (new pages only)

Additional checks run:
- `python3 scripts/docs-to-skills.py docs/ .agents/skills/ --prefix
nemoclaw-user --dry-run`
- `git diff --check`
- `make docs` passed with the existing local version-switcher read
message.
- Full `npx prek run --all-files` and `npm test` were skipped for this
doc-only automation run. Commit and pre-push hooks otherwise passed
docs, lint, secret, and conversion checks until the local `Test (skills
YAML)` hook failed because `vitest/config` is not installed in this
fresh worktree.

---
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Documentation**
* Updated Hermes quickstart: default sandbox name is "hermes"; guidance
to use distinct sandbox names, note same-name reuse is prevented, Hermes
wizard does not request Brave Web Search, and sandbox listings now show
agent type.
* Clarified provider onboarding: bounded in-sandbox smoke check runs
when Telegram messaging is enabled.
* Expanded Telegram docs: added TELEGRAM_REQUIRE_MENTION (DMs still
governed by TELEGRAM_ALLOWED_IDS), onboarding examples,
stop-messaging/tunnel behavior, and troubleshooting.
  * Promoted docs to version 0.0.33.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@wscurran wscurran added the bug-fix PR fixes a bug or regression label Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix PR fixes a bug or regression integration: hermes Hermes integration behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants